Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Issue 1161853008: skia: Simplify SSE2 logic a bit. (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

skia: Simplify SSE2 logic a bit. Chrome builds with -msse2 globally these days, so remove the skia_chrome_opts target and fold it into skia_chrome. Keep skia_opts but simplify the comments there a bit. No intended behavior change. BUG=496512, 348761 Committed: https://crrev.com/1281ac7b9bdc8979652725a57474f82d9e1145fe Cr-Commit-Position: refs/heads/master@{#333129}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -71 lines) Patch
M skia/BUILD.gn View 1 3 chunks +13 lines, -13 lines 0 comments Download
M skia/skia.gyp View 1 chunk +0 lines, -31 lines 0 comments Download
M skia/skia_chrome.gypi View 1 2 2 chunks +13 lines, -6 lines 0 comments Download
M skia/skia_library_opts.gyp View 2 chunks +8 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
5 years, 6 months ago (2015-06-05 19:09:26 UTC) #2
brettw
lgtm
5 years, 6 months ago (2015-06-05 19:36:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161853008/40001
5 years, 6 months ago (2015-06-05 19:42:54 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-05 20:57:39 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:59:39 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1281ac7b9bdc8979652725a57474f82d9e1145fe
Cr-Commit-Position: refs/heads/master@{#333129}

Powered by Google App Engine
This is Rietveld 408576698