Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1161853007: ozone: Remove "Delegate" from window management IPCs (Closed)

Created:
5 years, 6 months ago by spang
Modified:
5 years, 6 months ago
Reviewers:
kenrb, dnicoara
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Remove "Delegate" from window management IPCs It was removed from the class name but not the IPC names. Committed: https://crrev.com/570f6a1abd666725ab4bb0990028ee995037be4c Cr-Commit-Position: refs/heads/master@{#333161}

Patch Set 1 #

Patch Set 2 : also update comment #

Patch Set 3 : #

Patch Set 4 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M ui/ozone/common/gpu/ozone_gpu_messages.h View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_platform_support.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_platform_support.cc View 1 2 3 3 chunks +6 lines, -9 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_window_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
spang
dnicoara@ [everything] kenrb@ [IPC]
5 years, 6 months ago (2015-06-05 15:40:55 UTC) #2
dnicoara
lgtm
5 years, 6 months ago (2015-06-05 15:55:03 UTC) #4
kenrb
ipc lgtm
5 years, 6 months ago (2015-06-05 16:12:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161853007/20001
5 years, 6 months ago (2015-06-05 16:16:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/60025) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-05 16:21:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161853007/40001
5 years, 6 months ago (2015-06-05 17:13:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/60053) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-05 17:16:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161853007/60001
5 years, 6 months ago (2015-06-05 22:19:28 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-05 22:40:08 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 22:41:02 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/570f6a1abd666725ab4bb0990028ee995037be4c
Cr-Commit-Position: refs/heads/master@{#333161}

Powered by Google App Engine
This is Rietveld 408576698