Mac: Add partial swap support to NSOpenGLContext path

Mac: Add partial swap support to NSOpenGLContext path

Add a damage rect parameter to the structure
GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params.
Because that structure and its IPC are Mac-only, wrap them
in ifdefs.

Add code in the IOSurface draw function to clear out the
difference between the IOSurface and its viewport.

BUG=496484
Committed: https://crrev.com/2dc2466eb82ca759c60b94b15937e0a209fd4acd
Cr-Commit-Position: refs/heads/master@{#333231}

[ccameron, 2015-06-05 01:20:41]

ccameron@chromium.org changed reviewers:
+ kbr@chromium.org

[ccameron, 2015-06-05 01:20:42]

Lots of plumbing, but not much else going on here.

[Ken Russell (switch to Gerrit), 2015-06-05 21:43:27]

LGTM

Does this work when using the OpenGL Core Profile on Mac OS --
--enable-unsafe-es3-apis? The new OpenGL code is clearly using the compatibility
profile but maybe that's OK since it's entirely in the browser process?

https://codereview.chromium.org/1161853006/diff/20001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/io_surface_texture.mm (right):

https://codereview.chromium.org/1161853006/diff/20001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/io_surface_texture.mm:139: pixel_size_.height());
This looks wrong -- should this be (0, ...)?

[ccameron, 2015-06-05 22:46:22]

Thanks! Yes, this should be okay with the core profile, because it's entirely in
the browser process.

https://codereview.chromium.org/1161853006/diff/20001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/io_surface_texture.mm (right):

https://codereview.chromium.org/1161853006/diff/20001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/io_surface_texture.mm:139: pixel_size_.height());
On 2015/06/05 21:43:27, Ken Russell wrote:
> This looks wrong -- should this be (0, ...)?

Yes, this is wrong. Fixed.

[ccameron, 2015-06-05 22:47:34]

ccameron@chromium.org changed reviewers:
+ dcheng@chromium.org

[ccameron, 2015-06-05 22:47:34]

Adding dcheng@ for security review.

[dcheng, 2015-06-05 23:31:41]

ipc changes lgtm with some nits

https://codereview.chromium.org/1161853006/diff/20001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/accelerated_widget_mac.h (right):

https://codereview.chromium.org/1161853006/diff/20001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/accelerated_widget_mac.h:84: gfx::Rect
pixel_damage_rect,
I think gfx::rect (and gfx::Size) are usually passed by reference.

https://codereview.chromium.org/1161853006/diff/20001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/accelerated_widget_mac.h:103: gfx::Rect
pixel_damage_rect);
Ditto to passing by reference here and elsewhere.

[ccameron, 2015-06-07 19:48:23]

Thanks!

https://codereview.chromium.org/1161853006/diff/20001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/accelerated_widget_mac.h (right):

https://codereview.chromium.org/1161853006/diff/20001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/accelerated_widget_mac.h:84: gfx::Rect
pixel_damage_rect,
On 2015/06/05 23:31:41, dcheng wrote:
> I think gfx::rect (and gfx::Size) are usually passed by reference.

Done -- also changed all other functions' gfx::Size arguments in this file as
well.

https://codereview.chromium.org/1161853006/diff/20001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/accelerated_widget_mac.h:103: gfx::Rect
pixel_damage_rect);
On 2015/06/05 23:31:41, dcheng wrote:
> Ditto to passing by reference here and elsewhere.

Done.

[ccameron, 2015-06-07 20:12:14]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2015-06-07 20:12:14]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1161853006/#ps60001
(title: "Incorporate review feedback")

[commit-bot: I haz the power, 2015-06-07 20:12:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161853006/60001

[commit-bot: I haz the power, 2015-06-07 20:42:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-07 20:43:11]

Patchset 4 (id:??) landed as
https://crrev.com/2dc2466eb82ca759c60b94b15937e0a209fd4acd
Cr-Commit-Position: refs/heads/master@{#333231}