Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1161853004: Revert "Converting (Alt+LeftClick -> RightClick) to (Search+LeftClick -> RightClick)" (Closed)

Created:
5 years, 6 months ago by xdai1
Modified:
5 years, 6 months ago
Reviewers:
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Converting (Alt+LeftClick -> RightClick) to (Search+LeftClick -> RightClick)" on behalf of afakhry@. As seen in the buganizer discussion, users have gotten used to the broken behavior and are disrupted by the change without warning. This reverts commit 404d0118fa4c40676cbd2f6da3e5ba5d62f39b61. BUG=248762 TBR=afakhry@chromium.org Committed: https://crrev.com/e54b1fc21cb1fbb5f4532009ad8181432761657c Cr-Commit-Position: refs/heads/master@{#332979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -91 lines) Patch
M ash/accelerators/accelerator_filter_unittest.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 8 chunks +37 lines, -37 lines 0 comments Download
M ui/base/accelerators/accelerator_history.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/wm/core/accelerator_filter.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/wm/core/accelerator_filter.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161853004/1
5 years, 6 months ago (2015-06-05 00:53:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 00:59:48 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 01:01:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e54b1fc21cb1fbb5f4532009ad8181432761657c
Cr-Commit-Position: refs/heads/master@{#332979}

Powered by Google App Engine
This is Rietveld 408576698