Issue 1161843007: Don't run adb as part of shelldb boot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161843007: Don't run adb as part of shelldb boot (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
iansf, Chinmay

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Don't run adb as part of shelldb boot This defers running adb until we actually need the device-id which makes shelldb not crash when adb isn't avaiable. I also fixed to use ADB_PATH. Chinmay ran into this when trying shelldb on Mac. R=chinmaygarde@google.com, iansf@google.com Committed: https://chromium.googlesource.com/external/mojo/+/13a575743c02dab47db10d1da692ba367c70143b

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	sky/tools/shelldb	View		2 chunks	+7 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

eseidel

5 years, 6 months ago (2015-06-03 18:20:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
13a575743c02dab47db10d1da692ba367c70143b (presubmit successful).