Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1161833003: Make chrome_public_apk, not chrome_staging_java depend on chrome_template_resources (Closed)

Created:
5 years, 6 months ago by pkotwicz
Modified:
5 years, 6 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make chrome_public_apk, not chrome_staging_java depend on chrome_template_resources This CL fixes a bug where we were incorrectly building the chrome_template_resources target with manifest_package = "org.chromium.chrome" for internal Chrome builds. This CL makes chrome_public_apk (which is not shared with the internal build) depend on chrome_template_resources instead of chrome_staging_java (which is shared with the internal build). This allows the internal build to depend on a chrome_template_resources-like target which uses the correct package name. BUG=495428 TEST=None Committed: https://crrev.com/a73bdd5538ce40dd9e3a664ed5c42b2618f04d01 Cr-Commit-Position: refs/heads/master@{#333085}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M chrome/android/BUILD.gn View 1 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 1 5 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
pkotwicz
nyquist@, PTAL
5 years, 6 months ago (2015-06-02 22:42:25 UTC) #3
nyquist
lgtm
5 years, 6 months ago (2015-06-04 21:51:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161833003/60001
5 years, 6 months ago (2015-06-05 15:54:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/83857) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 6 months ago (2015-06-05 16:05:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161833003/80001
5 years, 6 months ago (2015-06-05 17:05:56 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 6 months ago (2015-06-05 17:39:03 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 18:03:26 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a73bdd5538ce40dd9e3a664ed5c42b2618f04d01
Cr-Commit-Position: refs/heads/master@{#333085}

Powered by Google App Engine
This is Rietveld 408576698