Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2043)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 116183005: Add support for rel=next to Prerender in Blink. (Closed)

Created:
7 years ago by gavinp
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, gavinp+prerender_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Add support for rel=next to Prerender in Blink. <link rel=next ...> elements are also used to drive prerenders. Let's parse them and pass them up to our embedder. BUG=329963 R=japhet@chromium.org,abarth,tburkard,davidben,jochen Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164241 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167099

Patch Set 1 #

Total comments: 2

Patch Set 2 : remediate, add unit test #

Patch Set 3 : rebase on top of cl 114863004 #

Patch Set 4 : add missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -15 lines) Patch
M Source/core/html/LinkRelAttribute.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/LinkRelAttribute.cpp View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/loader/LinkLoader.cpp View 1 2 2 chunks +17 lines, -4 lines 0 comments Download
M Source/core/loader/PrerenderHandle.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/PrerenderHandle.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/Prerender.h View 4 chunks +11 lines, -2 lines 0 comments Download
M Source/platform/Prerender.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/platform/exported/WebPrerender.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/tests/PrerenderingTest.cpp View 1 2 chunks +14 lines, -0 lines 0 comments Download
A Source/web/tests/data/prerender/rel_next_prerender.html View 1 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
gavinp
abarth, japhet: PTAL. davidben, tburkard, jochen: FYI. Note that https://codereview.chromium.org/113803003/ , a Chrome change, depends ...
7 years ago (2013-12-19 19:50:46 UTC) #1
abarth-chromium
Looks reasonable. I presume we're going to measure how effective this is. Is there a ...
7 years ago (2013-12-20 04:32:06 UTC) #2
gavinp
This rel type is definitely part of HTML, see http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#link-type-next . The meaning is stronger ...
7 years ago (2013-12-20 15:54:00 UTC) #3
abarth-chromium
lgtm Thanks!
7 years ago (2013-12-20 16:38:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/116183005/20001
7 years ago (2013-12-20 16:38:21 UTC) #5
commit-bot: I haz the power
Change committed as 164241
7 years ago (2013-12-20 17:52:14 UTC) #6
gavinp
On 2013/12/20 17:52:14, I haz the power (commit-bot) wrote: > Change committed as 164241 And ...
6 years, 10 months ago (2014-02-07 19:44:49 UTC) #7
gavinp
Annnnd, I've just uploaded a rebase of this on top of https://codereview.chromium.org/144863004/ , which will ...
6 years, 10 months ago (2014-02-07 20:11:20 UTC) #8
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-12 16:54:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/116183005/350001
6 years, 10 months ago (2014-02-12 16:54:42 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 17:38:18 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=18442
6 years, 10 months ago (2014-02-12 17:38:19 UTC) #12
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-12 21:07:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/116183005/350001
6 years, 10 months ago (2014-02-12 21:07:42 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 21:50:12 UTC) #15
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=18464
6 years, 10 months ago (2014-02-12 21:50:12 UTC) #16
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-12 22:27:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/116183005/350001
6 years, 10 months ago (2014-02-12 22:27:47 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 23:21:06 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=21581
6 years, 10 months ago (2014-02-12 23:21:06 UTC) #20
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-13 13:44:08 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/116183005/820001
6 years, 10 months ago (2014-02-13 13:44:22 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 15:31:32 UTC) #23
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=21887
6 years, 10 months ago (2014-02-13 15:31:36 UTC) #24
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-13 16:18:42 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/116183005/820001
6 years, 10 months ago (2014-02-13 16:19:10 UTC) #26
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 17:37:53 UTC) #27
Message was sent while issue was closed. 
Change committed as 167099

Powered by Google App Engine
This is Rietveld 408576698