Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1161823002: Correctly keep track of isolates for microtask execution (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
haraken, vivekg
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, falken, horo+watch_chromium.org, kinuko+worker_chromium.org, rwlbuis, sof, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Correctly keep track of isolates for microtask execution BUG=487155 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195985

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M Source/bindings/core/v8/V8RecursionScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Microtask.h View 2 chunks +2 lines, -1 line 1 comment Download
M Source/core/dom/Microtask.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebKit.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-27 14:35:39 UTC) #1
haraken
LGTM
5 years, 7 months ago (2015-05-27 14:52:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161823002/1
5 years, 7 months ago (2015-05-27 14:57:25 UTC) #4
vivekg
https://codereview.chromium.org/1161823002/diff/1/Source/core/dom/Microtask.h File Source/core/dom/Microtask.h (right): https://codereview.chromium.org/1161823002/diff/1/Source/core/dom/Microtask.h#newcode34 Source/core/dom/Microtask.h:34: #include "bindings/core/v8/ScriptState.h" nit: Do we need to include ScriptState.h ...
5 years, 7 months ago (2015-05-27 14:59:37 UTC) #6
jochen (gone - plz use gerrit)
On 2015/05/27 at 14:59:37, vivekg wrote: > https://codereview.chromium.org/1161823002/diff/1/Source/core/dom/Microtask.h > File Source/core/dom/Microtask.h (right): > > https://codereview.chromium.org/1161823002/diff/1/Source/core/dom/Microtask.h#newcode34 ...
5 years, 7 months ago (2015-05-27 15:30:07 UTC) #7
vivekg
On 2015/05/27 at 15:30:07, jochen wrote: > On 2015/05/27 at 14:59:37, vivekg wrote: > > ...
5 years, 7 months ago (2015-05-27 15:53:04 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 16:03:20 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195985

Powered by Google App Engine
This is Rietveld 408576698