Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: remoting/webapp/crd/js/gcd_client.js

Issue 1161813006: Updated handling of GCD devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: oops--ignore Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/remoting_webapp_files.gypi ('k') | remoting/webapp/crd/js/gcd_host_list_api.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/gcd_client.js
diff --git a/remoting/webapp/crd/js/gcd_client.js b/remoting/webapp/crd/js/gcd_client.js
index a2cac57af34c1064f412ba92b7a5073d32db6a8c..5bfab9fdef3ecc98a1fd2d9072bd05cd85a925d4 100644
--- a/remoting/webapp/crd/js/gcd_client.js
+++ b/remoting/webapp/crd/js/gcd_client.js
@@ -32,7 +32,9 @@ remoting.gcd.RegistrationTicket;
* TODO: Flesh out with typical fields.
* @typedef {{
* id:string,
- * name:string
+ * name:string,
+ * state:(!Object|undefined),
+ * tags:(!Array<string>|undefined)
* }}
*/
remoting.gcd.Device;
@@ -206,18 +208,12 @@ remoting.gcd.Client.prototype.finalizeRegistrationTicket = function(ticketId) {
/**
* Lists devices user has access to.
* TODO: Add link to GCD docs.
- * @param {string=} opt_nameSubstring If present, the list of devices
- * is filtered by GCD such that every device returned contains
- * this string as as a substring of its |name| or |displayName|.
* @return {!Promise<!Array<remoting.gcd.Device>>}
*/
-remoting.gcd.Client.prototype.listDevices = function(opt_nameSubstring) {
+remoting.gcd.Client.prototype.listDevices = function() {
return new remoting.Xhr({
method: 'GET',
url: this.apiBaseUrl_ + '/devices',
- urlParams: {
- nameSubstring: opt_nameSubstring || null
- },
useIdentity: true,
acceptJson: true
}).start().then(function(response) {
« no previous file with comments | « remoting/remoting_webapp_files.gypi ('k') | remoting/webapp/crd/js/gcd_host_list_api.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698