Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: remoting/webapp/crd/js/host_list_api_impl_unittest.js

Issue 1161813006: Updated handling of GCD devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for review; fixed broken host reg. algorithm Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/host_list_api_impl_unittest.js
diff --git a/remoting/webapp/crd/js/host_list_api_impl_unittest.js b/remoting/webapp/crd/js/host_list_api_impl_unittest.js
index 4e7bc3d861ca63d9892272306399eb32f14221b9..80661d937c84aee38645d2e746840001b8f7f809 100644
--- a/remoting/webapp/crd/js/host_list_api_impl_unittest.js
+++ b/remoting/webapp/crd/js/host_list_api_impl_unittest.js
@@ -17,12 +17,18 @@ var FAKE_PUBLIC_KEY = '<FAKE_PUBLIC_KEY>';
var FAKE_HOST_CLIENT_ID = '<FAKE_HOST_CLIENT_ID>';
var FAKE_AUTH_CODE = '<FAKE_AUTH_CODE>';
+/** @type {sinon.TestStub} */
+var generateUuidStub;
+
QUnit.module('host_list_api_impl', {
beforeEach: function(/** QUnit.Assert */ assert) {
remoting.settings = new remoting.Settings();
remoting.MockXhr.activate();
+ generateUuidStub = sinon.stub(base, 'generateUuid');
+ generateUuidStub.returns(FAKE_HOST_ID);
},
afterEach: function(/** QUnit.Assert */ assert) {
+ generateUuidStub.restore();
remoting.MockXhr.restore();
remoting.settings = null;
}
@@ -57,7 +63,6 @@ QUnit.test('register', function(assert) {
var impl = new remoting.HostListApiImpl();
queueRegistryResponse(assert);
return impl.register(
- FAKE_HOST_ID,
FAKE_HOST_NAME,
FAKE_PUBLIC_KEY,
FAKE_HOST_CLIENT_ID
@@ -72,7 +77,6 @@ QUnit.test('register failure', function(assert) {
remoting.MockXhr.setEmptyResponseFor(
'POST', 'DIRECTORY_API_BASE_URL/@me/hosts', 500);
return impl.register(
- FAKE_HOST_ID,
FAKE_HOST_NAME,
FAKE_PUBLIC_KEY,
FAKE_HOST_CLIENT_ID

Powered by Google App Engine
This is Rietveld 408576698