Updated handling of GCD devices.

remoting/webapp/crd/js/host_list_api_gcd_impl.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * REST API for host-list management.
  */
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 (function() {
 
 'use strict';
 
 /**
  * @constructor
  * @implements {remoting.HostListApi}
  */
 remoting.HostListApiGcdImpl = function() {
   this.gcd_ = new remoting.gcd.Client({
     apiKey: remoting.settings.GOOGLE_API_KEY
   });
 };
 
 /** @override */
 remoting.HostListApiGcdImpl.prototype.register = function(
-    newHostId, hostName, publicKey, hostClientId) {
+    hostName, publicKey, hostClientId) {
   var self = this;
   var deviceDraft = {
     channel: {
       supportedType: 'xmpp'
     },
     deviceKind: 'vendor',
-    name: newHostId,
-    displayName: hostName,
+    name: hostName,
     state: {
-      'publicKey': publicKey
-    }
+      'base': {

[Jamie, 2015/06/08 21:44:34]

Elsewhere in this file there are no quotes around object keys. I'm not sure
what's more common in our code-base, but we should aim to be consistent.

[John Williams, 2015/06/09 19:46:30]

Done.

+        'firmwareVersion': 'none',
+        'localDiscoveryEnabled': false,
+        'localAnonymousAccessMaxRole': 'none',
+        'localPairingEnabled': false,
+        '_publicKey': publicKey

[Jamie, 2015/06/08 21:44:34]

What's the significance of the leading underscore?

[John Williams, 2015/06/09 19:46:30]

Done.

+      }
+    },
+    'tags': [MAGIC_TAG]
   };
 
   return /** @type {!Promise<remoting.HostListApi.RegisterResult>} */ (
       this.gcd_.insertRegistrationTicket().
       then(function(ticket) {
         return self.gcd_.patchRegistrationTicket(
             ticket.id, deviceDraft, hostClientId);
       }).
       then(function(/**remoting.gcd.RegistrationTicket*/ ticket) {
         return self.gcd_.finalizeRegistrationTicket(ticket.id);
       }).
       then(function(/**remoting.gcd.RegistrationTicket*/ ticket) {
         return {
           authCode: ticket.robotAccountAuthorizationCode,
           email: ticket.robotAccountEmail,
-          gcdId: ticket.deviceId
+          hostId: ticket.deviceId,
+          isLegacy: false
         };
       }).
       catch(function(error) {
         console.error('Error registering device with GCD: ' + error);
         throw new remoting.Error(remoting.Error.Tag.REGISTRATION_FAILED);
       }));
 };
 
 /** @override */
 remoting.HostListApiGcdImpl.prototype.get = function() {
   return this.gcd_.listDevices().
       then(function(devices) {
         var hosts = [];
         devices.forEach(function(device) {
           try {
-            hosts.push(deviceToHost(device));
+            if (isChromotingHost(device)) {
+              hosts.push(deviceToHost(device));
+            }
           } catch (/** @type {*} */ error) {
             console.warn('Invalid device spec:', error);
           }
         });
         return hosts;
       });
 };
 
 /** @override */
 remoting.HostListApiGcdImpl.prototype.put =
     function(hostId, hostName, hostPublicKey) {
-  // TODO(jrw)
-  throw new Error('Not implemented');
+  return this.gcd_.patchDevice(hostId, {
+    'name': hostName
+  }).then(function(device) {
+    if (device.name != hostName) {
+      console.error('error updating host name');
+      throw remoting.Error.unexpected();
+    }
+    if (!device.state || device.state['_publicKey'] != hostPublicKey) {
+      // TODO(jrw): Is there any reason to believe this would ever be
+      // happen?
+      console.error('unexpected host public key');
+      throw remoting.Error.unexpected();
+    }
+    // Don't return anything.
+  });
 };
 
 /** @override */
 remoting.HostListApiGcdImpl.prototype.remove = function(hostId) {
-  var that = this;
-  return this.gcd_.listDevices(hostId).then(function(devices) {
-    var gcdId = null;
-    for (var i = 0; i < devices.length; i++) {
-      var device = devices[i];
-      // The "name" field in GCD holds what Chromoting considers to be
-      // the host ID.
-      if (device.name == hostId) {
-        gcdId = device.id;
-      }
+  return this.gcd_.deleteDevice(hostId).then(function(deleted) {
+    if (!deleted) {
+      console.error('error deleting host from GCD');
+      throw remoting.Error.unexpected();
     }
-    if (gcdId == null) {
-      return false;
-    } else {
-      return that.gcd_.deleteDevice(gcdId);
-    }
+    // Don't return anything.
   });
 };
 
 /** @override */
 remoting.HostListApiGcdImpl.prototype.getSupportHost = function(supportId) {
   console.error('getSupportHost not supported by HostListApiGclImpl');
   return Promise.reject(remoting.Error.unexpected());
 };
 
 /**
+ * Tag for distinguishing Chromoting hosts from other devices stores

[Jamie, 2015/06/08 21:44:34]

s/stores/stored/

[John Williams, 2015/06/09 19:46:30]

Done.

+ * in GCD.

[Jamie, 2015/06/08 21:44:34]

Blank line between description and annotations, please (here and below).

[John Williams, 2015/06/09 19:46:30]

Done.

+ * @const
+ */
+var MAGIC_TAG = '1ce4542c-dd87-4320-ba19-ac173f98c04e';

[Jamie, 2015/06/08 21:44:34]

Please give this a more descriptive name.

[John Williams, 2015/06/09 19:46:30]

Done.

+
+/**
+ * Check whether a GCD device entry is a Chromoting host.
+ * @param {remoting.gcd.Device} device
+ * @return {boolean}
+ */
+function isChromotingHost(device) {
+  return device.tags != null && device.tags.indexOf(MAGIC_TAG) != -1;
+}
+
+/**
  * Converts a GCD device description to a Host object.
  * @param {!Object} device
  * @return {!remoting.Host}
  */
 function deviceToHost(device) {
   var statusMap = {
     'online': 'ONLINE',
     'offline': 'OFFLINE'
   };
-  var hostId = base.getStringAttr(device, 'name');
+  var hostId = base.getStringAttr(device, 'id');
   var host = new remoting.Host(hostId);
-  host.hostName = base.getStringAttr(device, 'displayName');
+  host.hostName = base.getStringAttr(device, 'name');
   host.status = base.getStringAttr(
       statusMap, base.getStringAttr(device, 'connectionStatus'));
   var state = base.getObjectAttr(device, 'state', {});
-  host.publicKey = base.getStringAttr(state, 'publicKey');
-  host.jabberId = base.getStringAttr(state, 'jabberId', '');
-  host.hostVersion = base.getStringAttr(state, 'hostVersion', '');
+  var baseState = base.getObjectAttr(state, 'base', {});
+  host.publicKey = base.getStringAttr(baseState, '_publicKey');
+  host.jabberId = base.getStringAttr(baseState, '_jabberId', '');
+  host.hostVersion = base.getStringAttr(baseState, '_hostVersion', '');
   var creationTimeMs = base.getNumberAttr(device, 'creationTimeMs', 0);
   if (creationTimeMs) {
     host.createdTime = new Date(creationTimeMs).toISOString();
   }
   var lastUpdateTimeMs = base.getNumberAttr(device, 'lastUpdateTimeMs', 0);
   if (lastUpdateTimeMs) {
     host.updatedTime = new Date(lastUpdateTimeMs).toISOString();
   }
   return host;
 };
 
 })();