Reland "Roll DEPS to class-dump 3.5"

Reland "Roll DEPS to class-dump 3.5"

Removes some build warnings.

Moves the class-dump repo to a github auto-mirror instead of a mirror
that needs to be manually updated.

This also requires that the class-dump.gyp file move from the
third-party repo into the main source tree. Note that the file
structure of the class-dump source changed so the .gyp had to be
updated. For comparison, the old .class-dump.gyp can be found at
https://chromium.googlesource.com/chromium/deps/class-dump/+/master/class-dump.gyp

BUG=318160, 417264
Committed: https://crrev.com/b61668a8e23fcdbe8fd1e851c836a1a4d45fb054
Cr-Commit-Position: refs/heads/master@{#332485}

[justincohen, 2015-05-27 17:26:00]

justincohen@chromium.org changed reviewers:
+ thakis@chromium.org

[justincohen, 2015-05-27 17:26:01]

thakis@ I'm taking over this CL for lliabraa@, the original CL is here:
https://codereview.chromium.org/1147353003/

I moved the code into src/third_party to avoid the gclient problems, and updated
the warning list.

PTAL!

[justincohen, 2015-05-29 15:36:54]

bump

[Nico, 2015-05-30 03:52:58]

https://codereview.chromium.org/1161813003/diff/20001/third_party/class-dump/...
File third_party/class-dump/class-dump.gyp (right):

https://codereview.chromium.org/1161813003/diff/20001/third_party/class-dump/...
third_party/class-dump/class-dump.gyp:184:
'-Wno-arc-bridge-casts-disallowed-in-nonarc',
As requested on the other review, can you add short comments for each of these
and explain why they're safe to ignore?

[justincohen, 2015-05-31 23:20:18]

I pushed class-dump a bit further and converted to ARC, so now iossim/class-dump
builds warning free and could remove GCC_TREAT_WARNINGS_AS_ERRORS.

WDYT?

https://codereview.chromium.org/1161813003/diff/20001/third_party/class-dump/...
File third_party/class-dump/class-dump.gyp (right):

https://codereview.chromium.org/1161813003/diff/20001/third_party/class-dump/...
third_party/class-dump/class-dump.gyp:184:
'-Wno-arc-bridge-casts-disallowed-in-nonarc',
On 2015/05/30 03:52:58, Nico wrote:
> As requested on the other review, can you add short comments for each of these
> and explain why they're safe to ignore?

I rolled a bit further and enabled ARC, so these warnings are now gone.

[Nico, 2015-06-01 22:31:21]

Nice!

https://codereview.chromium.org/1161813003/diff/60001/testing/iossim/iossim.gyp
File testing/iossim/iossim.gyp (right):

https://codereview.chromium.org/1161813003/diff/60001/testing/iossim/iossim.g...
testing/iossim/iossim.gyp:120: ],
Do you need this block when you set the same thing unconditionally below?

https://codereview.chromium.org/1161813003/diff/60001/third_party/class-dump/...
File third_party/class-dump/README.chromium (right):

https://codereview.chromium.org/1161813003/diff/60001/third_party/class-dump/...
third_party/class-dump/README.chromium:10: Local Modifications:
Say which revision this is in this file too

https://codereview.chromium.org/1161813003/diff/60001/third_party/class-dump/...
File third_party/class-dump/class-dump.gyp (right):

https://codereview.chromium.org/1161813003/diff/60001/third_party/class-dump/...
third_party/class-dump/class-dump.gyp:181: 'MACOSX_DEPLOYMENT_TARGET': '10.8',
same question: Do you need this, it's set unconditionally below

https://codereview.chromium.org/1161813003/diff/60001/third_party/class-dump/...
third_party/class-dump/class-dump.gyp:188: 'OTHER_CFLAGS': ['-fobjc-arc'],
Do you need this? CLANG_ENABLE_OBJC_ARC: YES should add this automatically

[justincohen, 2015-06-02 01:20:40]

I don't have satisfying answers for the gyp questions.  Any ideas?

https://codereview.chromium.org/1161813003/diff/60001/testing/iossim/iossim.gyp
File testing/iossim/iossim.gyp (right):

https://codereview.chromium.org/1161813003/diff/60001/testing/iossim/iossim.g...
testing/iossim/iossim.gyp:120: ],
On 2015/06/01 22:31:21, Nico wrote:
> Do you need this block when you set the same thing unconditionally below?

GYP confuses me.  If I don't include the block above, the builds fail for ninja,
presumably because of the line in build/common.gypi here:
https://chromium.googlesource.com/chromium/src/build/+/master/common.gypi#5384

However, the MACOSX_DEPLOYMENT_TARGET set below on line 123 seems to work for
xcode builds.

https://codereview.chromium.org/1161813003/diff/60001/third_party/class-dump/...
File third_party/class-dump/README.chromium (right):

https://codereview.chromium.org/1161813003/diff/60001/third_party/class-dump/...
third_party/class-dump/README.chromium:10: Local Modifications:
On 2015/06/01 22:31:21, Nico wrote:
> Say which revision this is in this file too

Done.

https://codereview.chromium.org/1161813003/diff/60001/third_party/class-dump/...
File third_party/class-dump/class-dump.gyp (right):

https://codereview.chromium.org/1161813003/diff/60001/third_party/class-dump/...
third_party/class-dump/class-dump.gyp:181: 'MACOSX_DEPLOYMENT_TARGET': '10.8',
On 2015/06/01 22:31:21, Nico wrote:
> same question: Do you need this, it's set unconditionally below

Same answer.  I needed to set both for the compile to work on both xcode and
ninja -- but I don't quite understand why the unconditional below isn't enouch.

https://codereview.chromium.org/1161813003/diff/60001/third_party/class-dump/...
third_party/class-dump/class-dump.gyp:188: 'OTHER_CFLAGS': ['-fobjc-arc'],
On 2015/06/01 22:31:21, Nico wrote:
> Do you need this? CLANG_ENABLE_OBJC_ARC: YES should add this automatically

Done.

[Nico, 2015-06-02 03:30:06]

https://codereview.chromium.org/1161813003/diff/60001/testing/iossim/iossim.gyp
File testing/iossim/iossim.gyp (right):

https://codereview.chromium.org/1161813003/diff/60001/testing/iossim/iossim.g...
testing/iossim/iossim.gyp:7: ['OS!="ios" or "<(GENERATOR)"!="xcode" or
"<(GENERATOR_FLAVOR)"=="ninja"', {
Wait this block isn't even used with xcode. How can this have an effect there?

https://codereview.chromium.org/1161813003/diff/60001/testing/iossim/iossim.g...
testing/iossim/iossim.gyp:120: ],
On 2015/06/02 01:20:40, justincohen wrote:
> On 2015/06/01 22:31:21, Nico wrote:
> > Do you need this block when you set the same thing unconditionally below?
> 
> GYP confuses me.  If I don't include the block above, the builds fail for
ninja,
> presumably because of the line in build/common.gypi here:
> https://chromium.googlesource.com/chromium/src/build/+/master/common.gypi#5384

Ah, I guess the line below initializes it to 10.8, and target_conditions are
processed later so the line you linked to overwrites it.

> However, the MACOSX_DEPLOYMENT_TARGET set below on line 123 seems to work for
> xcode builds.  

…but then I don't understand why it would work for Xcode. Does it work with both
generators if you remove the lower setting?

Or can you set mac_deployment_target in the variables block on this target and
let build/common.gypi do the rest?

[justincohen, 2015-06-02 17:05:58]

mac_deployment_target simplified things, thanks!  PTAL!

https://codereview.chromium.org/1161813003/diff/60001/testing/iossim/iossim.gyp
File testing/iossim/iossim.gyp (right):

https://codereview.chromium.org/1161813003/diff/60001/testing/iossim/iossim.g...
testing/iossim/iossim.gyp:7: ['OS!="ios" or "<(GENERATOR)"!="xcode" or
"<(GENERATOR_FLAVOR)"=="ninja"', {
On 2015/06/02 03:30:06, Nico wrote:
> Wait this block isn't even used with xcode. How can this have an effect there?

xcode sub's out to ninja for this.

https://codereview.chromium.org/1161813003/diff/60001/testing/iossim/iossim.g...
testing/iossim/iossim.gyp:120: ],
On 2015/06/02 03:30:06, Nico wrote:
> On 2015/06/02 01:20:40, justincohen wrote:
> > On 2015/06/01 22:31:21, Nico wrote:
> > > Do you need this block when you set the same thing unconditionally below?
> > 
> > GYP confuses me.  If I don't include the block above, the builds fail for
> ninja,
> > presumably because of the line in build/common.gypi here:
> >
https://chromium.googlesource.com/chromium/src/build/+/master/common.gypi#5384
> 
> Ah, I guess the line below initializes it to 10.8, and target_conditions are
> processed later so the line you linked to overwrites it.
> 
> > However, the MACOSX_DEPLOYMENT_TARGET set below on line 123 seems to work
for
> > xcode builds.  
> 
> …but then I don't understand why it would work for Xcode. Does it work with
both
> generators if you remove the lower setting?
> 
> Or can you set mac_deployment_target in the variables block on this target and
> let build/common.gypi do the rest?

mac_deployment_target did the trick!

[Nico, 2015-06-02 18:11:24]

Cool, lgtm with a second OWNERS entry and the other comment answered

https://codereview.chromium.org/1161813003/diff/120001/third_party/class-dump...
File third_party/class-dump/OWNERS (right):

https://codereview.chromium.org/1161813003/diff/120001/third_party/class-dump...
third_party/class-dump/OWNERS:1: justincohen@chromium.org
https://www.chromium.org/developers/adding-3rd-party-libraries#TOC-Add-OWNERS

"Your OWNERS file must include 2 Chromium developer accounts." Can you find
someone to co-own this with you?

https://codereview.chromium.org/1161813003/diff/120001/third_party/class-dump...
File third_party/class-dump/class-dump.gyp (right):

https://codereview.chromium.org/1161813003/diff/120001/third_party/class-dump...
third_party/class-dump/class-dump.gyp:184:
'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'NO',
is this still needed?

[justincohen, 2015-06-02 18:17:50]

Done, PTAL!

https://codereview.chromium.org/1161813003/diff/120001/third_party/class-dump...
File third_party/class-dump/OWNERS (right):

https://codereview.chromium.org/1161813003/diff/120001/third_party/class-dump...
third_party/class-dump/OWNERS:1: justincohen@chromium.org
On 2015/06/02 18:11:24, Nico wrote:
> https://www.chromium.org/developers/adding-3rd-party-libraries#TOC-Add-OWNERS
> 
> "Your OWNERS file must include 2 Chromium developer accounts." Can you find
> someone to co-own this with you?

Done.

https://codereview.chromium.org/1161813003/diff/120001/third_party/class-dump...
File third_party/class-dump/class-dump.gyp (right):

https://codereview.chromium.org/1161813003/diff/120001/third_party/class-dump...
third_party/class-dump/class-dump.gyp:184:
'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'NO',
On 2015/06/02 18:11:24, Nico wrote:
> is this still needed?

Yes.

[justincohen, 2015-06-02 20:29:31]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2015-06-02 20:29:32]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1161813003/#ps140001
(title: "Add second OWNER")

[commit-bot: I haz the power, 2015-06-02 20:29:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161813003/140001

[commit-bot: I haz the power, 2015-06-02 23:11:43]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-06-02 23:13:35]

Patchset 8 (id:??) landed as
https://crrev.com/b61668a8e23fcdbe8fd1e851c836a1a4d45fb054
Cr-Commit-Position: refs/heads/master@{#332485}