Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11618049: Cleanup: Remove unneeded browser_thread.h includes in contents. (Closed)

Created:
8 years ago by Lei Zhang
Modified:
7 years, 11 months ago
Reviewers:
joth, jam
CC:
chromium-reviews, michaeln, vsevik, yusukes+watch_chromium.org, stuartmorgan+watch_chromium.org, benjhayden+dwatch_chromium.org, tzik+watch_chromium.org, jam, penghuang+watch_chromium.org, yurys, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org, rdsmith+dwatch_chromium.org, pam+watch_chromium.org, kinuko+watch, James Su, pfeldman
Visibility:
Public.

Description

Cleanup: Remove unneeded browser_thread.h includes in contents. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174922

Patch Set 1 #

Patch Set 2 : lint #

Patch Set 3 : fix build #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -38 lines) Patch
M android_webview/browser/aw_browser_main_parts.h View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_download_observer.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_file_helper.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_installer.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_mac.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 1 2 3 4 5 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/android/content_video_view.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/android/media_player_manager_android.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/appcache/chrome_appcache_service.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/appcache/chrome_appcache_service.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/devtools_tracing_handler.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/save_file_resource_handler.h View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/fileapi/chrome_blob_storage_context.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/fileapi/chrome_blob_storage_context.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gamepad/gamepad_provider.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gamepad/gamepad_service.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/async_resource_handler.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/doomed_resource_handler.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/loader/resource_handler.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_message_filter.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/transfer_navigation_resource_throttle.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/power_save_blocker_mac.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_udp_socket.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.mm View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/speech/google_streaming_remote_engine.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/utility_process_host_impl.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/browser_main_parts.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/browser_ppapi_host.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/download_manager.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/utility_process_host.h View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
8 years ago (2012-12-21 01:37:01 UTC) #1
jam
lgtm https://codereview.chromium.org/11618049/diff/2012/android_webview/browser/aw_browser_main_parts.h File android_webview/browser/aw_browser_main_parts.h (right): https://codereview.chromium.org/11618049/diff/2012/android_webview/browser/aw_browser_main_parts.h#newcode10 android_webview/browser/aw_browser_main_parts.h:10: #include "base/message_loop.h" nit: can forward declare too
8 years ago (2012-12-21 02:21:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11618049/14013
8 years ago (2012-12-21 03:43:52 UTC) #3
commit-bot: I haz the power
Presubmit check for 11618049-14013 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-21 03:44:04 UTC) #4
Lei Zhang
8 years ago (2012-12-21 04:23:58 UTC) #5
joth
lgtm
7 years, 12 months ago (2012-12-21 22:53:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11618049/14013
7 years, 12 months ago (2012-12-21 22:56:18 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
7 years, 12 months ago (2012-12-22 03:15:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11618049/38001
7 years, 11 months ago (2013-01-02 21:08:12 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-02 21:19:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11618049/43007
7 years, 11 months ago (2013-01-02 23:48:04 UTC) #11
commit-bot: I haz the power
7 years, 11 months ago (2013-01-03 02:41:28 UTC) #12
Message was sent while issue was closed. 
Change committed as 174922

Powered by Google App Engine
This is Rietveld 408576698