Issue 1161803005: DevTools: WI.ElementsSidebarViewWrapperPane should append into bodyElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161803005: DevTools: WI.ElementsSidebarViewWrapperPane should append into bodyElement (Closed)

Created:
4 years, 11 months ago by lushnikov

Modified:
4 years, 11 months ago

Reviewers:
sergeyv, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: WI.ElementsSidebarViewWrapperPane should append into bodyElement EventListenersWidget uses some styles from the sidebarPane.css. In order to keep them working, we should add widgets into sidebar pane's bodyElement. BUG=496098 R=sergeyv, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196488

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/devtools/front_end/elements/ElementsSidebarView.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lushnikov

In the long run, all styles needed for EventListenersWidget and others should be moved into ...

4 years, 11 months ago (2015-06-03 14:16:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161803005/1

4 years, 11 months ago (2015-06-04 09:19:00 UTC) #5

commit-bot: I haz the power

4 years, 11 months ago (2015-06-04 10:24:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196488

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages