Issue 1161803002: Add early-out in SVGTextChunkBuilder::finalizeTransformMatrices()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161803002: Add early-out in SVGTextChunkBuilder::finalizeTransformMatrices() (Closed)

Created:
5 years, 7 months ago by fs

Modified:
5 years, 7 months ago

Reviewers:
pdr., f(malita)

CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add early-out in SVGTextChunkBuilder::finalizeTransformMatrices() This function will only do something when textLength is being applied. If that's not the case, there'll just a lot of iteration and hash- lookups for no good. Not huge win performance-wise (in the noise), but a fairly simple and obvious thing to do. BUG=486669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195983

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	Source/core/layout/svg/SVGTextChunkBuilder.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161803002/1

5 years, 7 months ago (2015-05-27 15:05:16 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-27 15:43:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195983

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages