Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: cc/software_renderer_unittest.cc

Issue 11618026: Move filters to RenderPassDrawQuad (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/software_renderer_unittest.cc
diff --git a/cc/software_renderer_unittest.cc b/cc/software_renderer_unittest.cc
index 21e5d6f3144dec84a3f72aeee68bbc9e1064bad3..bac30537719773bc0bf964893edf1094786cb252 100644
--- a/cc/software_renderer_unittest.cc
+++ b/cc/software_renderer_unittest.cc
@@ -90,10 +90,8 @@ TEST_F(SoftwareRendererTest, solidColorQuad)
rootRenderPass->AppendQuad(outerQuad.PassAs<DrawQuad>());
RenderPassList list;
- RenderPassIdHashMap hashmap;
list.push_back(rootRenderPass.get());
- hashmap.add(rootRenderPassId, rootRenderPass.PassAs<RenderPass>());
- renderer()->drawFrame(list, hashmap);
+ renderer()->drawFrame(list);
scoped_array<SkColor> pixels(new SkColor[deviceViewportSize().width() * deviceViewportSize().height()]);
renderer()->getFramebufferPixels(pixels.get(), outerRect);
@@ -151,10 +149,8 @@ TEST_F(SoftwareRendererTest, tileQuad)
rootRenderPass->AppendQuad(outerQuad.PassAs<DrawQuad>());
RenderPassList list;
- RenderPassIdHashMap hashmap;
list.push_back(rootRenderPass.get());
- hashmap.add(rootRenderPassId, rootRenderPass.PassAs<RenderPass>());
- renderer()->drawFrame(list, hashmap);
+ renderer()->drawFrame(list);
scoped_array<SkColor> pixels(new SkColor[deviceViewportSize().width() * deviceViewportSize().height()]);
renderer()->getFramebufferPixels(pixels.get(), outerRect);
@@ -174,7 +170,6 @@ TEST_F(SoftwareRendererTest, shouldClearRootRenderPass)
initializeRenderer();
RenderPassList list;
- RenderPassIdHashMap hashmap;
ScopedPtrVector<RenderPass> renderPasses;
scoped_array<SkColor> pixels(new SkColor[viewportPixels]);
@@ -184,17 +179,15 @@ TEST_F(SoftwareRendererTest, shouldClearRootRenderPass)
addQuad(rootClearPass, viewportRect, SK_ColorGREEN);
list.push_back(rootClearPass);
- hashmap.set(rootClearPassId, renderPasses.take(0));
renderer()->decideRenderPassAllocationsForFrame(list);
- renderer()->drawFrame(list, hashmap);
+ renderer()->drawFrame(list);
renderer()->getFramebufferPixels(pixels.get(), viewportRect);
EXPECT_EQ(SK_ColorGREEN, pixels[0]);
EXPECT_EQ(SK_ColorGREEN, pixels[viewportPixels - 1]);
renderPasses.clear();
- hashmap.clear();
list.clear();
// Draw a smaller magenta rect without filling the viewport in a separate frame.
@@ -205,10 +198,9 @@ TEST_F(SoftwareRendererTest, shouldClearRootRenderPass)
addQuad(rootSmallerPass, smallerRect, SK_ColorMAGENTA);
list.push_back(rootSmallerPass);
- hashmap.set(rootSmallerPassId, renderPasses.take(0));
renderer()->decideRenderPassAllocationsForFrame(list);
- renderer()->drawFrame(list, hashmap);
+ renderer()->drawFrame(list);
renderer()->getFramebufferPixels(pixels.get(), viewportRect);
// If we didn't clear, the borders should still be green.

Powered by Google App Engine
This is Rietveld 408576698