Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4053)

Unified Diff: cc/gl_renderer_unittest.cc

Issue 11618026: Move filters to RenderPassDrawQuad (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/gl_renderer_unittest.cc
diff --git a/cc/gl_renderer_unittest.cc b/cc/gl_renderer_unittest.cc
index b4741cda242b1d5889621baaf63b1786e22766f6..a989483e0131b32b84dacbafc9b6ee05a848f654 100644
--- a/cc/gl_renderer_unittest.cc
+++ b/cc/gl_renderer_unittest.cc
@@ -73,7 +73,6 @@ public:
scoped_ptr<RenderPass> rootRenderPass = RenderPass::Create();
rootRenderPass->SetNew(renderPassId, gfx::Rect(), gfx::Rect(), gfx::Transform());
m_renderPassesInDrawOrder.push_back(rootRenderPass.get());
- m_renderPasses.set(renderPassId, rootRenderPass.Pass());
}
// RendererClient methods.
@@ -95,7 +94,6 @@ public:
RenderPass* rootRenderPass() { return m_renderPassesInDrawOrder.back(); }
RenderPassList& renderPassesInDrawOrder() { return m_renderPassesInDrawOrder; }
- RenderPassIdHashMap& renderPasses() { return m_renderPasses; }
size_t memoryAllocationLimitBytes() const { return m_memoryAllocationLimitBytes; }
@@ -106,7 +104,6 @@ private:
bool* m_lastCallWasSetVisibility;
scoped_ptr<LayerImpl> m_rootLayer;
RenderPassList m_renderPassesInDrawOrder;
- RenderPassIdHashMap m_renderPasses;
size_t m_memoryAllocationLimitBytes;
};
@@ -218,7 +215,7 @@ TEST_F(GLRendererTest, DiscardedBackbufferIsRecreatedForScopeDuration)
EXPECT_EQ(1, m_mockClient.setFullRootLayerDamageCount());
m_renderer.setVisible(true);
- m_renderer.drawFrame(m_mockClient.renderPassesInDrawOrder(), m_mockClient.renderPasses());
+ m_renderer.drawFrame(m_mockClient.renderPassesInDrawOrder());
EXPECT_FALSE(m_renderer.isBackbufferDiscarded());
swapBuffers();
@@ -233,7 +230,7 @@ TEST_F(GLRendererTest, FramebufferDiscardedAfterReadbackWhenNotVisible)
EXPECT_EQ(1, m_mockClient.setFullRootLayerDamageCount());
char pixels[4];
- m_renderer.drawFrame(m_mockClient.renderPassesInDrawOrder(), m_mockClient.renderPasses());
+ m_renderer.drawFrame(m_mockClient.renderPassesInDrawOrder());
EXPECT_FALSE(m_renderer.isBackbufferDiscarded());
m_renderer.getFramebufferPixels(pixels, gfx::Rect(0, 0, 1, 1));
@@ -412,7 +409,7 @@ TEST(GLRendererTest2, opaqueBackground)
EXPECT_TRUE(renderer.initialize());
- renderer.drawFrame(mockClient.renderPassesInDrawOrder(), mockClient.renderPasses());
+ renderer.drawFrame(mockClient.renderPassesInDrawOrder());
// On DEBUG builds, render passes with opaque background clear to blue to
// easily see regions that were not drawn on the screen.
@@ -435,7 +432,7 @@ TEST(GLRendererTest2, transparentBackground)
EXPECT_TRUE(renderer.initialize());
- renderer.drawFrame(mockClient.renderPassesInDrawOrder(), mockClient.renderPasses());
+ renderer.drawFrame(mockClient.renderPassesInDrawOrder());
EXPECT_EQ(1, context->clearCount());
}
@@ -492,7 +489,7 @@ TEST(GLRendererTest2, visibilityChangeIsLastCall)
context->setLastCallWasSetVisibilityPointer(&lastCallWasSetVisiblity);
mockClient.setLastCallWasSetVisibilityPointer(&lastCallWasSetVisiblity);
renderer.setVisible(true);
- renderer.drawFrame(mockClient.renderPassesInDrawOrder(), mockClient.renderPasses());
+ renderer.drawFrame(mockClient.renderPassesInDrawOrder());
renderer.setVisible(false);
EXPECT_TRUE(lastCallWasSetVisiblity);
}
@@ -620,8 +617,6 @@ TEST(GLRendererTest2, shouldClearRootRenderPass)
mockClient.renderPassesInDrawOrder().clear();
mockClient.renderPassesInDrawOrder().push_back(childPass);
mockClient.renderPassesInDrawOrder().push_back(rootPass);
- mockClient.renderPasses().set(rootPassId, renderPasses.take(0));
- mockClient.renderPasses().set(childPassId, renderPasses.take(1));
// First render pass is not the root one, clearing should happen.
EXPECT_CALL(*mockContext, clear(GL_COLOR_BUFFER_BIT))
@@ -640,7 +635,7 @@ TEST(GLRendererTest2, shouldClearRootRenderPass)
.After(firstRenderPass);
renderer.decideRenderPassAllocationsForFrame(mockClient.renderPassesInDrawOrder());
- renderer.drawFrame(mockClient.renderPassesInDrawOrder(), mockClient.renderPasses());
+ renderer.drawFrame(mockClient.renderPassesInDrawOrder());
// In multiple render passes all but the root pass should clear the framebuffer.
Mock::VerifyAndClearExpectations(&mockContext);

Powered by Google App Engine
This is Rietveld 408576698