[signin] Support for CrOS and OAuth2AccessTokenConsumer services.

chrome/browser/policy/user_policy_signin_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/user_policy_signin_service.h"
 
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/policy/cloud_policy_service.h"
 #include "chrome/browser/policy/user_cloud_policy_manager.h"
 #include "chrome/browser/policy/user_cloud_policy_manager_factory.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/signin/about_signin_internals.h"
+#include "chrome/browser/signin/about_signin_internals_factory.h"
 #include "chrome/browser/signin/signin_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/token_service.h"
 #include "chrome/browser/signin/token_service_factory.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "google_apis/gaia/gaia_constants.h"
 #include "google_apis/gaia/gaia_urls.h"
 #include "google_apis/gaia/oauth2_access_token_fetcher.h"
 
+using content::BrowserThread;
+
 namespace {
 // Various OAuth service scopes required to do CloudPolicyClient registration.
 const char kServiceScopeChromeOSDeviceManagement[] =
     "https://www.googleapis.com/auth/chromeosdevicemanagement";
 const char kServiceScopeGetUserInfo[] =
     "https://www.googleapis.com/auth/userinfo.email";
 
 // The key under which the hosted-domain value is stored in the UserInfo
 // response.
 const char kGetHostedDomainKey[] = "hd";
@@ skipping 242 matching lines @@
       gaia_urls->oauth2_chrome_client_id(),
       gaia_urls->oauth2_chrome_client_secret(),
       login_token,
       scopes);
 }
 
 void UserPolicySigninService::OnGetTokenFailure(
     const GoogleServiceAuthError& error) {
   DLOG(WARNING) << "Could not fetch access token for "
                 << kServiceScopeChromeOSDeviceManagement;
+
+  // TODO(vishwath): This can be removed when refactoring this class to use
+  // OAuth2TokenService instead.
+  // Let AboutSigninInternals know about the failed token fetch.
+  DCHECK(profile_);

[Mattias Nissler (ping if slow), 2012/12/20 09:16:11]

Any good reason for this DCHECK? If |profile_| is NULL, you'll get a crash
anyways.

+  AboutSigninInternalsFactory::GetForProfile(profile_)->
+      NotifyTokenReceivedFailure(
+          signin_internals_util::kUserPolicySigninServiceToken,
+          error.ToString());
+
   oauth2_access_token_fetcher_.reset();
   // If there was a pending fetch request, let them know the fetch failed.
   NotifyPendingFetchCallback(false);
 }
 
 void UserPolicySigninService::OnGetTokenSuccess(
     const std::string& access_token,
     const base::Time& expiration_time) {
+  // Pass along the new access token to the CloudPolicyClient.

[Mattias Nissler (ping if slow), 2012/12/20 09:16:11]

nit: This comment is stale and probably a merge artifact. Please remove.

   oauth_access_token_ = access_token;
-  DVLOG(1) << "Fetched new scoped OAuth token:" << oauth_access_token_;
+  DVLOG(1) << "Fetched new scoped OAuth token:" << access_token;
+
+  // TODO(vishwath): This can be removed when refactoring this class to use
+  // OAuth2TokenService instead.

[Andrew T Wilson (Slow), 2012/12/21 11:42:29]

Remove this comment, as we are not going to refactor this class to use
OAuth2TokenService (the reason is that this code is executed as part of profile
startup, so it needs to run before either TokenService or OAuth2TokenService is
initialized).

+  DCHECK(profile_);

[Mattias Nissler (ping if slow), 2012/12/20 09:16:11]

same here.

+  AboutSigninInternalsFactory::GetForProfile(profile_)->
+      NotifyTokenReceivedSuccess(
+          signin_internals_util::kUserPolicySigninServiceToken,
+          access_token,
+          true);
+
   oauth2_access_token_fetcher_.reset();
   // Now we've gotten our access token - contact GAIA to see if this is a
   // hosted domain.
   user_info_fetcher_.reset(new UserInfoFetcher(this,
                                                profile_->GetRequestContext()));
   user_info_fetcher_->Start(oauth_access_token_);
 }
 
 void UserPolicySigninService::OnGetUserInfoFailure(
     const GoogleServiceAuthError& error) {
@@ skipping 51 matching lines @@
 
 void UserPolicySigninService::Shutdown() {
   StopObserving();
 }
 
 UserCloudPolicyManager* UserPolicySigninService::GetManager() {
   return UserCloudPolicyManagerFactory::GetForProfile(profile_);
 }
 
 }  // namespace policy