[Autofill] Don't hold onto stale form field pointers

[Autofill] Don't hold onto stale form field pointers

Delete old references when new form data is being parsed.

BUG=495102
Committed: https://crrev.com/bd002c0484db244b493d9eeb671d9476024c1b33
Cr-Commit-Position: refs/heads/master@{#333168}

[Evan Stade, 2015-06-05 00:26:14]

estade@chromium.org changed reviewers:
+ thestig@chromium.org

[Evan Stade, 2015-06-05 00:26:15]

probably a good idea to wait for green try bots before reviewing

[Lei Zhang, 2015-06-05 03:45:35]

https://codereview.chromium.org/1161793006/diff/20001/components/autofill/con...
File components/autofill/content/renderer/form_cache.cc (right):

https://codereview.chromium.org/1161793006/diff/20001/components/autofill/con...
components/autofill/content/renderer/form_cache.cc:328: const
WebFormControlElement& element = control_elements[i];
for (const WebFOrmControlElement& element : control_elements)

https://codereview.chromium.org/1161793006/diff/20001/components/autofill/con...
components/autofill/content/renderer/form_cache.cc:335: const WebInputElement
input_element = element.toConst<WebInputElement>();
The 3 subclasses of WebFormControlElement are WebSelectElement, WebInputElement,
and WebTextAreaElement. With the refactoring here, this is no longer
guaranteeded to be a WebInputElement.

[Evan Stade, 2015-06-05 22:16:43]

https://codereview.chromium.org/1161793006/diff/20001/components/autofill/con...
File components/autofill/content/renderer/form_cache.cc (right):

https://codereview.chromium.org/1161793006/diff/20001/components/autofill/con...
components/autofill/content/renderer/form_cache.cc:328: const
WebFormControlElement& element = control_elements[i];
On 2015/06/05 03:45:35, Lei Zhang wrote:
> for (const WebFOrmControlElement& element : control_elements)

Done.

https://codereview.chromium.org/1161793006/diff/20001/components/autofill/con...
components/autofill/content/renderer/form_cache.cc:335: const WebInputElement
input_element = element.toConst<WebInputElement>();
On 2015/06/05 03:45:35, Lei Zhang wrote:
> The 3 subclasses of WebFormControlElement are WebSelectElement,
WebInputElement,
> and WebTextAreaElement. With the refactoring here, this is no longer
> guaranteeded to be a WebInputElement.

fixed, I guess

[Lei Zhang, 2015-06-05 22:45:19]

lgtm

[Evan Stade, 2015-06-05 22:49:04]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-06-05 22:50:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161793006/40001

[commit-bot: I haz the power, 2015-06-05 23:09:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-05 23:11:39]

Patchset 3 (id:??) landed as
https://crrev.com/bd002c0484db244b493d9eeb671d9476024c1b33
Cr-Commit-Position: refs/heads/master@{#333168}