LayoutTests/fast/events/touch/create-touch-event-source-device.html - Issue 1161783006: Populates sourceDevice attribute into TouchEvent

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/touch/create-touch-event-source-device.html

Issue 1161783006: Populates sourceDevice attribute into TouchEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: sourceDevice set to null from Javascript Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <p id="description"></p>

	8 <div id="console"></div>

	9 <script type="text/javascript">

	10 description('Test that touch events should have a sourceDevice and its firesTouc hEvents should be true.');

	11

	12 var event = null;

	13

	14 try

	15 {

	16 event = document.createEvent("TouchEvent");

	17 shouldBeNonNull("event");

	18 shouldBeNull("event.sourceDevice");

	19 }

	20 catch (e)

	21 {

	22 testFailed("An exception was thrown: " + e.message);
	tdresser 2015/06/08 12:36:39 What exception are you worried about here? Would What exception are you worried about here? Would switching to: if(event !== null) shouldBeNull("event.sourceDevice"); be just as good? lanwei 2015/06/09 20:07:10 You are right, if it is null, the test will fail. Show quoted text On 2015/06/08 12:36:39, tdresser wrote: > What exception are you worried about here? > > Would switching to: > > if(event !== null) > shouldBeNull("event.sourceDevice"); > > be just as good? You are right, if it is null, the test will fail. We do not need catch exception.
	23 }

	24

	25 </script>

	26 </body>

	27 </html>

OLD	NEW