Populates sourceDevice attribute into TouchEvent

Populates sourceDevice attribute into TouchEvent

Since now we have InputDevice information, in this CL we populates sourceDevice
attribute into TouchEvent, which has firesTouchEvents set to be true.

The Intent-to-Implement: UIEvent.sourceDevice & InputDevice.firesTouchEvents link:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/inputdevice/blink-dev/wjtZl9jpCpI/xC0JTRKgc9kJ 

This CL is depended on Issue 1157173003, which creates the InputDevice class
(https://codereview.chromium.org/1157173003/)
and Issue 1160753005, which Implement UIEvent.sourceDevice
(https://codereview.chromium.org/1160753005/)

BUG=476530
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196967

[lanwei, 2015-06-03 15:55:42]

lanwei@chromium.org changed reviewers:
+ rbyers@chromium.org, tdresser@chromium.org

[lanwei, 2015-06-03 16:15:22]

Patchset #1 (id:1) has been deleted

[tdresser, 2015-06-03 17:50:39]

https://codereview.chromium.org/1161783006/diff/20001/LayoutTests/fast/events...
File LayoutTests/fast/events/touch/create-touch-event-source-device.html
(right):

https://codereview.chromium.org/1161783006/diff/20001/LayoutTests/fast/events...
LayoutTests/fast/events/touch/create-touch-event-source-device.html:19:
shouldBeTrue("event.sourceDevice.firesTouchEvents");
Should this be true? There isn't really a sourceDevice here...

https://codereview.chromium.org/1161783006/diff/20001/LayoutTests/fast/events...
LayoutTests/fast/events/touch/create-touch-event-source-device.html:20: 
nit: Remove space.

https://codereview.chromium.org/1161783006/diff/20001/LayoutTests/fast/events...
File LayoutTests/fast/events/touch/touch-event-source-device-event-sender.html
(right):

https://codereview.chromium.org/1161783006/diff/20001/LayoutTests/fast/events...
LayoutTests/fast/events/touch/touch-event-source-device-event-sender.html:48: 
Too many blank lines!

https://codereview.chromium.org/1161783006/diff/20001/Source/core/events/Touc...
File Source/core/events/TouchEvent.cpp (right):

https://codereview.chromium.org/1161783006/diff/20001/Source/core/events/Touc...
Source/core/events/TouchEvent.cpp:42: sourceDevice()->setFiresTouchEvents(true);
Shouldn't this use touchEventInstance?

https://codereview.chromium.org/1161783006/diff/20001/Source/core/events/Touc...
Source/core/events/TouchEvent.cpp:51: : UIEventWithKeyState(type, true,
cancelable, view, 0, sourceDevice, ctrlKey, altKey, shiftKey, metaKey)
Shouldn't this use touchEventInstance?

[lanwei, 2015-06-05 19:30:00]

Patchset #2 (id:40001) has been deleted

[lanwei, 2015-06-05 19:30:13]

Patchset #2 (id:60001) has been deleted

[lanwei, 2015-06-05 21:30:44]

Patchset #2 (id:80001) has been deleted

[lanwei, 2015-06-05 21:33:12]

https://codereview.chromium.org/1161783006/diff/20001/LayoutTests/fast/events...
File LayoutTests/fast/events/touch/create-touch-event-source-device.html
(right):

https://codereview.chromium.org/1161783006/diff/20001/LayoutTests/fast/events...
LayoutTests/fast/events/touch/create-touch-event-source-device.html:20: 
On 2015/06/03 17:50:39, tdresser wrote:
> nit: Remove space.

Done.

https://codereview.chromium.org/1161783006/diff/20001/LayoutTests/fast/events...
File LayoutTests/fast/events/touch/touch-event-source-device-event-sender.html
(right):

https://codereview.chromium.org/1161783006/diff/20001/LayoutTests/fast/events...
LayoutTests/fast/events/touch/touch-event-source-device-event-sender.html:48: 
On 2015/06/03 17:50:39, tdresser wrote:
> Too many blank lines!

Done.

[tdresser, 2015-06-08 12:36:40]

Some of the bot failures are due to your patch - can you take a look?

https://codereview.chromium.org/1161783006/diff/100001/LayoutTests/fast/event...
File LayoutTests/fast/events/touch/create-touch-event-source-device.html
(right):

https://codereview.chromium.org/1161783006/diff/100001/LayoutTests/fast/event...
LayoutTests/fast/events/touch/create-touch-event-source-device.html:22:
testFailed("An exception was thrown: " + e.message);
What exception are you worried about here?

Would switching to:

if(event !== null)
  shouldBeNull("event.sourceDevice");

be just as good?

https://codereview.chromium.org/1161783006/diff/100001/Source/core/events/Tou...
File Source/core/events/TouchEvent.cpp (right):

https://codereview.chromium.org/1161783006/diff/100001/Source/core/events/Tou...
Source/core/events/TouchEvent.cpp:49: : UIEventWithKeyState(type, true,
cancelable, view, 0, InputDevice::touchEventInstance(),
Add a comment on why it's okay to set sourceDevice to touchEventInstance() here.

I assume it's okay because we only call this method for input triggered touches?

https://codereview.chromium.org/1161783006/diff/100001/Source/core/events/UIE...
File Source/core/events/UIEventWithKeyState.h (right):

https://codereview.chromium.org/1161783006/diff/100001/Source/core/events/UIE...
Source/core/events/UIEventWithKeyState.h:65: int detail, InputDevice*
sourceDevice, bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
Where is this called?

https://codereview.chromium.org/1161783006/diff/100001/Source/core/input/Inpu...
File Source/core/input/InputDevice.h (right):

https://codereview.chromium.org/1161783006/diff/100001/Source/core/input/Inpu...
Source/core/input/InputDevice.h:24: static InputDevice* nonTouchEventInstance();
Where is this used?

[lanwei, 2015-06-09 19:26:49]

Patchset #3 (id:120001) has been deleted

[lanwei, 2015-06-09 20:07:10]

https://codereview.chromium.org/1161783006/diff/100001/LayoutTests/fast/event...
File LayoutTests/fast/events/touch/create-touch-event-source-device.html
(right):

https://codereview.chromium.org/1161783006/diff/100001/LayoutTests/fast/event...
LayoutTests/fast/events/touch/create-touch-event-source-device.html:22:
testFailed("An exception was thrown: " + e.message);
On 2015/06/08 12:36:39, tdresser wrote:
> What exception are you worried about here?
> 
> Would switching to:
> 
> if(event !== null)
>   shouldBeNull("event.sourceDevice");
> 
> be just as good?

You are right, if it is null, the test will fail. We do not need catch
exception.

https://codereview.chromium.org/1161783006/diff/100001/Source/core/events/UIE...
File Source/core/events/UIEventWithKeyState.h (right):

https://codereview.chromium.org/1161783006/diff/100001/Source/core/events/UIE...
Source/core/events/UIEventWithKeyState.h:65: int detail, InputDevice*
sourceDevice, bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
On 2015/06/08 12:36:39, tdresser wrote:
> Where is this called?

It is called when constructing a touch event as a input not from javascript .

https://codereview.chromium.org/1161783006/diff/100001/Source/core/input/Inpu...
File Source/core/input/InputDevice.h (right):

https://codereview.chromium.org/1161783006/diff/100001/Source/core/input/Inpu...
Source/core/input/InputDevice.h:24: static InputDevice* nonTouchEventInstance();
On 2015/06/08 12:36:40, tdresser wrote:
> Where is this used?

It will be used later for other uievents which are not fired from touch screen.

[lanwei, 2015-06-09 20:09:53]

The test inspector-protocol/input/emulateTouchFromMouseEvent.html which failed
in linux_blink_rel passed in my local build.

On 2015/06/09 20:07:10, lanwei wrote:
>
https://codereview.chromium.org/1161783006/diff/100001/LayoutTests/fast/event...
> File LayoutTests/fast/events/touch/create-touch-event-source-device.html
> (right):
> 
>
https://codereview.chromium.org/1161783006/diff/100001/LayoutTests/fast/event...
> LayoutTests/fast/events/touch/create-touch-event-source-device.html:22:
> testFailed("An exception was thrown: " + e.message);
> On 2015/06/08 12:36:39, tdresser wrote:
> > What exception are you worried about here?
> > 
> > Would switching to:
> > 
> > if(event !== null)
> >   shouldBeNull("event.sourceDevice");
> > 
> > be just as good?
> 
> You are right, if it is null, the test will fail. We do not need catch
> exception.
> 
>
https://codereview.chromium.org/1161783006/diff/100001/Source/core/events/UIE...
> File Source/core/events/UIEventWithKeyState.h (right):
> 
>
https://codereview.chromium.org/1161783006/diff/100001/Source/core/events/UIE...
> Source/core/events/UIEventWithKeyState.h:65: int detail, InputDevice*
> sourceDevice, bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
> On 2015/06/08 12:36:39, tdresser wrote:
> > Where is this called?
> 
> It is called when constructing a touch event as a input not from javascript .
> 
>
https://codereview.chromium.org/1161783006/diff/100001/Source/core/input/Inpu...
> File Source/core/input/InputDevice.h (right):
> 
>
https://codereview.chromium.org/1161783006/diff/100001/Source/core/input/Inpu...
> Source/core/input/InputDevice.h:24: static InputDevice*
nonTouchEventInstance();
> On 2015/06/08 12:36:40, tdresser wrote:
> > Where is this used?
> 
> It will be used later for other uievents which are not fired from touch
screen.

[tdresser, 2015-06-10 13:46:00]

https://codereview.chromium.org/1161783006/diff/200001/Source/core/events/Tou...
File Source/core/events/TouchEvent.cpp (right):

https://codereview.chromium.org/1161783006/diff/200001/Source/core/events/Tou...
Source/core/events/TouchEvent.cpp:50: : UIEventWithKeyState(type, true,
cancelable, view, 0, ctrlKey, altKey, shiftKey, metaKey,
InputDevice::touchEventInstance())
This comment doesn't make it clear why we're assuming that this event is being
created by user input.

https://codereview.chromium.org/1161783006/diff/200001/Source/core/input/Inpu...
File Source/core/input/InputDevice.h (right):

https://codereview.chromium.org/1161783006/diff/200001/Source/core/input/Inpu...
Source/core/input/InputDevice.h:24: static InputDevice* nonTouchEventInstance();
Let's remove this until we use it.

[tdresser, 2015-06-10 13:48:05]

https://codereview.chromium.org/1161783006/diff/200001/LayoutTests/fast/event...
File LayoutTests/fast/events/touch/touch-event-source-device-event-sender.html
(right):

https://codereview.chromium.org/1161783006/diff/200001/LayoutTests/fast/event...
LayoutTests/fast/events/touch/touch-event-source-device-event-sender.html:43:
debug('This test requires --run-layout-test.');
We normally say 'This test requires eventSender'.

[lanwei, 2015-06-10 15:37:55]

Patchset #7 (id:220001) has been deleted

[lanwei, 2015-06-10 21:14:47]

Patchset #9 (id:270001) has been deleted

[lanwei, 2015-06-10 22:09:30]

Patchset #7 (id:230001) has been deleted

[lanwei, 2015-06-10 22:09:39]

Patchset #7 (id:250001) has been deleted

[lanwei, 2015-06-10 22:43:18]

Patchset #7 (id:290001) has been deleted

[lanwei, 2015-06-10 23:23:22]

https://codereview.chromium.org/1161783006/diff/200001/LayoutTests/fast/event...
File LayoutTests/fast/events/touch/touch-event-source-device-event-sender.html
(right):

https://codereview.chromium.org/1161783006/diff/200001/LayoutTests/fast/event...
LayoutTests/fast/events/touch/touch-event-source-device-event-sender.html:43:
debug('This test requires --run-layout-test.');
On 2015/06/10 13:48:05, tdresser wrote:
> We normally say 'This test requires eventSender'.

Done.

https://codereview.chromium.org/1161783006/diff/200001/Source/core/events/Tou...
File Source/core/events/TouchEvent.cpp (right):

https://codereview.chromium.org/1161783006/diff/200001/Source/core/events/Tou...
Source/core/events/TouchEvent.cpp:50: : UIEventWithKeyState(type, true,
cancelable, view, 0, ctrlKey, altKey, shiftKey, metaKey,
InputDevice::touchEventInstance())
On 2015/06/10 13:46:00, tdresser wrote:
> This comment doesn't make it clear why we're assuming that this event is being
> created by user input.

Done.

https://codereview.chromium.org/1161783006/diff/200001/Source/core/input/Inpu...
File Source/core/input/InputDevice.h (right):

https://codereview.chromium.org/1161783006/diff/200001/Source/core/input/Inpu...
Source/core/input/InputDevice.h:24: static InputDevice* nonTouchEventInstance();
On 2015/06/10 13:46:00, tdresser wrote:
> Let's remove this until we use it.

Done.

[Rick Byers, 2015-06-11 03:34:12]

LGTM

https://codereview.chromium.org/1161783006/diff/310001/LayoutTests/fast/event...
File LayoutTests/fast/events/touch/create-touch-event-source-device.html
(right):

https://codereview.chromium.org/1161783006/diff/310001/LayoutTests/fast/event...
LayoutTests/fast/events/touch/create-touch-event-source-device.html:3: <head>
nit: coding style says to omit unnecessary tags like html, head and body:
https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-...

https://codereview.chromium.org/1161783006/diff/310001/LayoutTests/fast/event...
LayoutTests/fast/events/touch/create-touch-event-source-device.html:14:
shouldBeNull("event.sourceDevice");
this is a pretty trivial test case - may be simpler to just lump it into your
uievent-with-inputdevice.html test?

[tdresser, 2015-06-11 12:52:29]

On 2015/06/11 03:34:12, Rick Byers wrote:
> LGTM
> 
>
https://codereview.chromium.org/1161783006/diff/310001/LayoutTests/fast/event...
> File LayoutTests/fast/events/touch/create-touch-event-source-device.html
> (right):
> 
>
https://codereview.chromium.org/1161783006/diff/310001/LayoutTests/fast/event...
> LayoutTests/fast/events/touch/create-touch-event-source-device.html:3: <head>
> nit: coding style says to omit unnecessary tags like html, head and body:
>
https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-...
> 
>
https://codereview.chromium.org/1161783006/diff/310001/LayoutTests/fast/event...
> LayoutTests/fast/events/touch/create-touch-event-source-device.html:14:
> shouldBeNull("event.sourceDevice");
> this is a pretty trivial test case - may be simpler to just lump it into your
> uievent-with-inputdevice.html test?

LGTM modulo rbyers' comments.

[lanwei, 2015-06-11 17:46:25]

The CQ bit was checked by lanwei@chromium.org

[lanwei, 2015-06-11 17:46:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1161783006/#ps330001
(title: "Put touchevent in uievent layout test")

[commit-bot: I haz the power, 2015-06-11 17:46:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161783006/330001

[commit-bot: I haz the power, 2015-06-11 19:19:00]

Committed patchset #8 (id:330001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196967

[lanwei, 2015-06-15 18:22:01]

https://codereview.chromium.org/1161783006/diff/310001/LayoutTests/fast/event...
File LayoutTests/fast/events/touch/create-touch-event-source-device.html
(right):

https://codereview.chromium.org/1161783006/diff/310001/LayoutTests/fast/event...
LayoutTests/fast/events/touch/create-touch-event-source-device.html:3: <head>
On 2015/06/11 03:34:12, Rick Byers wrote:
> nit: coding style says to omit unnecessary tags like html, head and body:
>
https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-...

Done.

https://codereview.chromium.org/1161783006/diff/310001/LayoutTests/fast/event...
LayoutTests/fast/events/touch/create-touch-event-source-device.html:14:
shouldBeNull("event.sourceDevice");
On 2015/06/11 03:34:12, Rick Byers wrote:
> this is a pretty trivial test case - may be simpler to just lump it into your
> uievent-with-inputdevice.html test?

Done.