Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1161773003: Remove unused method in html_document (Closed)

Created:
5 years, 6 months ago by Srirama
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused method in html_document Blink has been updated long time ago to use the new createMediaPlayer method, so removing this unused old method. TEST=compiles BUG=350571 Committed: https://crrev.com/dca49897b2a0938dab1811f1072a1196bbba2854 Cr-Commit-Position: refs/heads/master@{#332033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M components/html_viewer/html_document.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/html_viewer/html_document.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
Srirama
This is required for landing https://codereview.chromium.org/1125353004/. PTAL
5 years, 6 months ago (2015-05-29 16:40:45 UTC) #2
philipj_slow
Non-owner LGTM
5 years, 6 months ago (2015-05-29 16:46:10 UTC) #3
Srirama
brettw@chromium.org: Owners review please.
5 years, 6 months ago (2015-05-29 16:57:40 UTC) #5
brettw
I don't know anything about this component, removing myself. Generally you should pick owners as ...
5 years, 6 months ago (2015-05-29 17:18:31 UTC) #6
jrummell
lgtm
5 years, 6 months ago (2015-05-29 17:43:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161773003/1
5 years, 6 months ago (2015-05-29 17:45:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/66872)
5 years, 6 months ago (2015-05-29 17:56:10 UTC) #11
Srirama
sky@:Owner's review please.
5 years, 6 months ago (2015-05-29 18:54:54 UTC) #13
sky
LGTM
5 years, 6 months ago (2015-05-29 19:16:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161773003/1
5 years, 6 months ago (2015-05-29 20:03:52 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 20:10:18 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 20:11:20 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dca49897b2a0938dab1811f1072a1196bbba2854
Cr-Commit-Position: refs/heads/master@{#332033}

Powered by Google App Engine
This is Rietveld 408576698