Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Unified Diff: Source/platform/scroll/ScrollAnimator.h

Issue 1161713004: Rename ScrollableArea::scroll to userScroll (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/mac/ScrollAnimatorMac.mm ('k') | Source/platform/scroll/ScrollAnimator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/scroll/ScrollAnimator.h
diff --git a/Source/platform/scroll/ScrollAnimator.h b/Source/platform/scroll/ScrollAnimator.h
index 484ca0f8c0180a4c2f0e56bd24e46c30f33c5eff..be6d8bd21caf9498715c1987b984a76ab3e71a39 100644
--- a/Source/platform/scroll/ScrollAnimator.h
+++ b/Source/platform/scroll/ScrollAnimator.h
@@ -50,11 +50,12 @@ public:
virtual ~ScrollAnimator();
- // Computes a scroll destination for the given parameters. Returns false if
- // already at the destination. Otherwise, starts scrolling towards the
- // destination and returns true. Scrolling may be immediate or animated.
- // The base class implementation always scrolls immediately, never animates.
- virtual ScrollResultOneDimensional scroll(ScrollbarOrientation, ScrollGranularity, float step, float delta);
+ // Computes a scroll destination for the given parameters. The returned
+ // ScrollResultOneDimensional will have didScroll set to false if already at
+ // the destination. Otherwise, starts scrolling towards the destination and
+ // didScroll is true. Scrolling may be immediate or animated. The base
+ // class implementation always scrolls immediately, never animates.
+ virtual ScrollResultOneDimensional userScroll(ScrollbarOrientation, ScrollGranularity, float step, float delta);
virtual void scrollToOffsetWithoutAnimation(const FloatPoint&);
« no previous file with comments | « Source/platform/mac/ScrollAnimatorMac.mm ('k') | Source/platform/scroll/ScrollAnimator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698