Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Side by Side Diff: Source/web/tests/ScrollAnimatorNoneTest.cpp

Issue 1161713004: Rename ScrollableArea::scroll to userScroll (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/scroll/Scrollbar.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 TEST(ScrollAnimatorEnabled, Enabled) 117 TEST(ScrollAnimatorEnabled, Enabled)
118 { 118 {
119 MockScrollableArea scrollableArea(true); 119 MockScrollableArea scrollableArea(true);
120 RefPtr<MockScrollAnimatorNone> scrollAnimatorNone = MockScrollAnimatorNone:: create(&scrollableArea); 120 RefPtr<MockScrollAnimatorNone> scrollAnimatorNone = MockScrollAnimatorNone:: create(&scrollableArea);
121 121
122 EXPECT_CALL(scrollableArea, scrollSize(_)).Times(AtLeast(1)).WillRepeatedly( Return(1000)); 122 EXPECT_CALL(scrollableArea, scrollSize(_)).Times(AtLeast(1)).WillRepeatedly( Return(1000));
123 EXPECT_CALL(scrollableArea, minimumScrollPosition()).Times(AtLeast(1)).WillR epeatedly(Return(IntPoint())); 123 EXPECT_CALL(scrollableArea, minimumScrollPosition()).Times(AtLeast(1)).WillR epeatedly(Return(IntPoint()));
124 EXPECT_CALL(scrollableArea, maximumScrollPosition()).Times(AtLeast(1)).WillR epeatedly(Return(IntPoint(1000, 1000))); 124 EXPECT_CALL(scrollableArea, maximumScrollPosition()).Times(AtLeast(1)).WillR epeatedly(Return(IntPoint(1000, 1000)));
125 EXPECT_CALL(scrollableArea, setScrollOffset(_)).Times(4); 125 EXPECT_CALL(scrollableArea, setScrollOffset(_)).Times(4);
126 126
127 scrollAnimatorNone->scroll(HorizontalScrollbar, ScrollByLine, 100, 1); 127 scrollAnimatorNone->userScroll(HorizontalScrollbar, ScrollByLine, 100, 1);
128 EXPECT_NE(100, scrollAnimatorNone->currentX()); 128 EXPECT_NE(100, scrollAnimatorNone->currentX());
129 EXPECT_NE(0, scrollAnimatorNone->currentX()); 129 EXPECT_NE(0, scrollAnimatorNone->currentX());
130 EXPECT_EQ(0, scrollAnimatorNone->currentY()); 130 EXPECT_EQ(0, scrollAnimatorNone->currentY());
131 scrollAnimatorNone->reset(); 131 scrollAnimatorNone->reset();
132 132
133 scrollAnimatorNone->scroll(HorizontalScrollbar, ScrollByPage, 100, 1); 133 scrollAnimatorNone->userScroll(HorizontalScrollbar, ScrollByPage, 100, 1);
134 EXPECT_NE(100, scrollAnimatorNone->currentX()); 134 EXPECT_NE(100, scrollAnimatorNone->currentX());
135 EXPECT_NE(0, scrollAnimatorNone->currentX()); 135 EXPECT_NE(0, scrollAnimatorNone->currentX());
136 EXPECT_EQ(0, scrollAnimatorNone->currentY()); 136 EXPECT_EQ(0, scrollAnimatorNone->currentY());
137 scrollAnimatorNone->reset(); 137 scrollAnimatorNone->reset();
138 138
139 scrollAnimatorNone->scroll(HorizontalScrollbar, ScrollByPixel, 4, 25); 139 scrollAnimatorNone->userScroll(HorizontalScrollbar, ScrollByPixel, 4, 25);
140 EXPECT_NE(100, scrollAnimatorNone->currentX()); 140 EXPECT_NE(100, scrollAnimatorNone->currentX());
141 EXPECT_NE(0, scrollAnimatorNone->currentX()); 141 EXPECT_NE(0, scrollAnimatorNone->currentX());
142 EXPECT_EQ(0, scrollAnimatorNone->currentY()); 142 EXPECT_EQ(0, scrollAnimatorNone->currentY());
143 scrollAnimatorNone->reset(); 143 scrollAnimatorNone->reset();
144 144
145 scrollAnimatorNone->scroll(HorizontalScrollbar, ScrollByPrecisePixel, 4, 25) ; 145 scrollAnimatorNone->userScroll(HorizontalScrollbar, ScrollByPrecisePixel, 4, 25);
146 EXPECT_EQ(100, scrollAnimatorNone->currentX()); 146 EXPECT_EQ(100, scrollAnimatorNone->currentX());
147 EXPECT_NE(0, scrollAnimatorNone->currentX()); 147 EXPECT_NE(0, scrollAnimatorNone->currentX());
148 EXPECT_EQ(0, scrollAnimatorNone->currentY()); 148 EXPECT_EQ(0, scrollAnimatorNone->currentY());
149 scrollAnimatorNone->reset(); 149 scrollAnimatorNone->reset();
150 } 150 }
151 151
152 TEST(ScrollAnimatorEnabled, Disabled) 152 TEST(ScrollAnimatorEnabled, Disabled)
153 { 153 {
154 MockScrollableArea scrollableArea(false); 154 MockScrollableArea scrollableArea(false);
155 RefPtr<MockScrollAnimatorNone> scrollAnimatorNone = MockScrollAnimatorNone:: create(&scrollableArea); 155 RefPtr<MockScrollAnimatorNone> scrollAnimatorNone = MockScrollAnimatorNone:: create(&scrollableArea);
156 156
157 EXPECT_CALL(scrollableArea, minimumScrollPosition()).Times(AtLeast(1)).WillR epeatedly(Return(IntPoint())); 157 EXPECT_CALL(scrollableArea, minimumScrollPosition()).Times(AtLeast(1)).WillR epeatedly(Return(IntPoint()));
158 EXPECT_CALL(scrollableArea, maximumScrollPosition()).Times(AtLeast(1)).WillR epeatedly(Return(IntPoint(1000, 1000))); 158 EXPECT_CALL(scrollableArea, maximumScrollPosition()).Times(AtLeast(1)).WillR epeatedly(Return(IntPoint(1000, 1000)));
159 EXPECT_CALL(scrollableArea, setScrollOffset(_)).Times(4); 159 EXPECT_CALL(scrollableArea, setScrollOffset(_)).Times(4);
160 160
161 scrollAnimatorNone->scroll(HorizontalScrollbar, ScrollByLine, 100, 1); 161 scrollAnimatorNone->userScroll(HorizontalScrollbar, ScrollByLine, 100, 1);
162 EXPECT_EQ(100, scrollAnimatorNone->currentX()); 162 EXPECT_EQ(100, scrollAnimatorNone->currentX());
163 EXPECT_EQ(0, scrollAnimatorNone->currentY()); 163 EXPECT_EQ(0, scrollAnimatorNone->currentY());
164 scrollAnimatorNone->reset(); 164 scrollAnimatorNone->reset();
165 165
166 scrollAnimatorNone->scroll(HorizontalScrollbar, ScrollByPage, 100, 1); 166 scrollAnimatorNone->userScroll(HorizontalScrollbar, ScrollByPage, 100, 1);
167 EXPECT_EQ(100, scrollAnimatorNone->currentX()); 167 EXPECT_EQ(100, scrollAnimatorNone->currentX());
168 EXPECT_EQ(0, scrollAnimatorNone->currentY()); 168 EXPECT_EQ(0, scrollAnimatorNone->currentY());
169 scrollAnimatorNone->reset(); 169 scrollAnimatorNone->reset();
170 170
171 scrollAnimatorNone->scroll(HorizontalScrollbar, ScrollByDocument, 100, 1); 171 scrollAnimatorNone->userScroll(HorizontalScrollbar, ScrollByDocument, 100, 1 );
172 EXPECT_EQ(100, scrollAnimatorNone->currentX()); 172 EXPECT_EQ(100, scrollAnimatorNone->currentX());
173 EXPECT_EQ(0, scrollAnimatorNone->currentY()); 173 EXPECT_EQ(0, scrollAnimatorNone->currentY());
174 scrollAnimatorNone->reset(); 174 scrollAnimatorNone->reset();
175 175
176 scrollAnimatorNone->scroll(HorizontalScrollbar, ScrollByPixel, 100, 1); 176 scrollAnimatorNone->userScroll(HorizontalScrollbar, ScrollByPixel, 100, 1);
177 EXPECT_EQ(100, scrollAnimatorNone->currentX()); 177 EXPECT_EQ(100, scrollAnimatorNone->currentX());
178 EXPECT_EQ(0, scrollAnimatorNone->currentY()); 178 EXPECT_EQ(0, scrollAnimatorNone->currentY());
179 scrollAnimatorNone->reset(); 179 scrollAnimatorNone->reset();
180 } 180 }
181 181
182 class ScrollAnimatorNoneTest : public testing::Test { 182 class ScrollAnimatorNoneTest : public testing::Test {
183 public: 183 public:
184 struct SavePerAxisData : public ScrollAnimatorNone::PerAxisData { 184 struct SavePerAxisData : public ScrollAnimatorNone::PerAxisData {
185 SavePerAxisData(const ScrollAnimatorNone::PerAxisData& data) 185 SavePerAxisData(const ScrollAnimatorNone::PerAxisData& data)
186 : ScrollAnimatorNone::PerAxisData(0, 768) 186 : ScrollAnimatorNone::PerAxisData(0, 768)
(...skipping 861 matching lines...) Expand 10 before | Expand all | Expand 10 after
1048 EXPECT_TRUE(result); 1048 EXPECT_TRUE(result);
1049 result = result && animateScroll(t); 1049 result = result && animateScroll(t);
1050 double after = m_currentPosition; 1050 double after = m_currentPosition;
1051 EXPECT_GE(before, after); 1051 EXPECT_GE(before, after);
1052 1052
1053 t += kAnimationTime; 1053 t += kAnimationTime;
1054 for (; result && t < kEndTime; t += kAnimationTime) 1054 for (; result && t < kEndTime; t += kAnimationTime)
1055 result = result && animateScroll(t); 1055 result = result && animateScroll(t);
1056 EXPECT_GE(before, m_currentPosition); 1056 EXPECT_GE(before, m_currentPosition);
1057 } 1057 }
OLDNEW
« no previous file with comments | « Source/platform/scroll/Scrollbar.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698