Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1161713004: Rename ScrollableArea::scroll to userScroll (Closed)

Created:
5 years, 6 months ago by bokan
Modified:
5 years, 6 months ago
Reviewers:
Ian Vollick, skobes
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, rjwright, zoltan1, blink-reviews-animation_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, shans, blink-reviews-events_chromium.org, dglazkov+blink, blink-reviews-rendering, jchaffraix+rendering, darktears, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename ScrollableArea::scroll to userScroll There's lots of ways to scroll a ScrollableArea. The new name makes it clear that it should only be used on scrolls occuring as a result of a user gesture. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196406

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -50 lines) Patch
M Source/core/frame/LocalFrame.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/RootFrameViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/RootFrameViewport.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/RootFrameViewportTest.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/scroll/ScrollAnimator.h View 1 1 chunk +6 lines, -5 lines 0 comments Download
M Source/platform/scroll/ScrollAnimator.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/scroll/ScrollAnimatorNone.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollAnimatorNone.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/scroll/Scrollbar.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/ScrollAnimatorNoneTest.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
bokan
Split out from the mega-patch, name change look ok?
5 years, 6 months ago (2015-06-02 18:51:35 UTC) #2
skobes
lgtm :) https://codereview.chromium.org/1161713004/diff/1/Source/platform/scroll/ScrollAnimator.h File Source/platform/scroll/ScrollAnimator.h (right): https://codereview.chromium.org/1161713004/diff/1/Source/platform/scroll/ScrollAnimator.h#newcode54 Source/platform/scroll/ScrollAnimator.h:54: // ScrollResult will have didScroll set to ...
5 years, 6 months ago (2015-06-02 19:03:16 UTC) #3
bokan
+Ian for Source/platform and Source/core/page https://codereview.chromium.org/1161713004/diff/1/Source/platform/scroll/ScrollAnimator.h File Source/platform/scroll/ScrollAnimator.h (right): https://codereview.chromium.org/1161713004/diff/1/Source/platform/scroll/ScrollAnimator.h#newcode54 Source/platform/scroll/ScrollAnimator.h:54: // ScrollResult will have ...
5 years, 6 months ago (2015-06-02 21:06:25 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161713004/20001
5 years, 6 months ago (2015-06-02 21:50:56 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-03 00:39:51 UTC) #10
Ian Vollick
On 2015/06/03 at 00:39:51, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
5 years, 6 months ago (2015-06-03 15:10:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161713004/20001
5 years, 6 months ago (2015-06-03 15:11:31 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 15:14:58 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196406

Powered by Google App Engine
This is Rietveld 408576698