Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 11617016: Componentize webkit/compositor_bindings target (Closed)

Created:
8 years ago by jamesr
Modified:
8 years ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Componentize webkit/compositor_bindings target This is in preparation for using the compositor bindings code outside of webkit_glue.dll, for instance inside content.dll Also removes WebDelegatedRendererLayer support since it isn't needed. BUG=156175 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174011

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : fix win linkage warnings #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : add ui dep to cc_test_support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -151 lines) Patch
M cc/cc_tests.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M webkit/compositor_bindings/compositor_bindings.gyp View 1 2 3 4 chunks +13 lines, -3 lines 0 comments Download
M webkit/compositor_bindings/web_animation_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_animation_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/web_compositor_support_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_compositor_support_impl.cc View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
M webkit/compositor_bindings/web_compositor_support_output_surface.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_compositor_support_software_output_device.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_content_layer_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_content_layer_impl.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
D webkit/compositor_bindings/web_delegated_renderer_layer_impl.h View 1 chunk +0 lines, -30 lines 0 comments Download
D webkit/compositor_bindings/web_delegated_renderer_layer_impl.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M webkit/compositor_bindings/web_external_texture_layer_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_external_texture_layer_impl.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/web_float_animation_curve_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_float_animation_curve_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/web_image_layer_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_image_layer_impl.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/web_io_surface_layer_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_io_surface_layer_impl.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/web_layer_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_layer_impl.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_layer_unittest.cc View 1 2 3 4 5 6 7 chunks +9 lines, -6 lines 0 comments Download
M webkit/compositor_bindings/web_scrollbar_layer_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_scrollbar_layer_impl.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/compositor_bindings/web_solid_color_layer_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_solid_color_layer_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/web_transform_animation_curve_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_transform_animation_curve_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/web_video_layer_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_video_layer_impl.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
A webkit/compositor_bindings/webkit_compositor_bindings_export.h View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
This patch is on top of https://codereview.chromium.org/11615020/
8 years ago (2012-12-18 09:03:46 UTC) #1
piman
lgtm
8 years ago (2012-12-18 16:27:11 UTC) #2
enne (OOO)
lgtm2, although what's the rationale for just exporting the constructors?
8 years ago (2012-12-18 18:09:49 UTC) #3
jamesr
On 2012/12/18 18:09:49, enne wrote: > lgtm2, although what's the rationale for just exporting the ...
8 years ago (2012-12-18 20:45:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11617016/36002
8 years ago (2012-12-19 19:23:01 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-19 22:07:23 UTC) #6
Message was sent while issue was closed.
Change committed as 174011

Powered by Google App Engine
This is Rietveld 408576698