Refactor PepperFlashFileHost and PepperBrokerHost to use MessageFilterHost.

Refactor PepperFlashFileHost and PepperBrokerHost to use MessageFilterHost.

This refactors PepperFlashFileHost and PepperBrokerHost to use MessageFilterHost. This removes the empty Host classes and moves the interface definition of the MessageFilter classes into the header files. This hopefully makes the code a lot cleaner/clearer.

TBR=brettw@chromium.org for gypi changes and trivial plugin_data_remover_impl changes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174323

[raymes, 2012-12-18 03:28:53]

This CL may help for context: https://codereview.chromium.org/11601004/

Let me know if you have any questions. Thanks!

[dmichael (off chromium), 2012-12-19 22:57:31]

I *think* I understand it :-)

lgtm

https://codereview.chromium.org/11617005/diff/2001/chrome/browser/renderer_ho...
File chrome/browser/renderer_host/pepper/pepper_broker_message_filter.h (right):

https://codereview.chromium.org/11617005/diff/2001/chrome/browser/renderer_ho...
chrome/browser/renderer_host/pepper/pepper_broker_message_filter.h:37:
ppapi::host::HostMessageContext* context) OVERRIDE;
these could be private, right?

https://codereview.chromium.org/11617005/diff/2001/content/browser/renderer_h...
File content/browser/renderer_host/pepper/pepper_flash_file_message_filter.h
(right):

https://codereview.chromium.org/11617005/diff/2001/content/browser/renderer_h...
content/browser/renderer_host/pepper/pepper_flash_file_message_filter.h:48:
ppapi::host::HostMessageContext* context) OVERRIDE;
private?

[raymes, 2012-12-20 11:34:35]

https://codereview.chromium.org/11617005/diff/2001/chrome/browser/renderer_ho...
File chrome/browser/renderer_host/pepper/pepper_broker_message_filter.h (right):

https://codereview.chromium.org/11617005/diff/2001/chrome/browser/renderer_ho...
chrome/browser/renderer_host/pepper/pepper_broker_message_filter.h:37:
ppapi::host::HostMessageContext* context) OVERRIDE;
Oh I didn't know that derived class method visibility could be different to the
base class. Thanks!

https://codereview.chromium.org/11617005/diff/2001/content/browser/renderer_h...
File content/browser/renderer_host/pepper/pepper_flash_file_message_filter.h
(right):

https://codereview.chromium.org/11617005/diff/2001/content/browser/renderer_h...
content/browser/renderer_host/pepper/pepper_flash_file_message_filter.h:48:
ppapi::host::HostMessageContext* context) OVERRIDE;
On 2012/12/19 22:57:31, dmichael wrote:
> private?

Done.

[commit-bot: I haz the power, 2012-12-20 19:39:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/11617005/19001

[commit-bot: I haz the power, 2012-12-20 23:54:06]

Retried try job too often on win_rel for step(s) content_browsertests

[commit-bot: I haz the power, 2012-12-21 00:56:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/11617005/30002

[commit-bot: I haz the power, 2012-12-21 01:50:12]

Retried try job too often on win_rel for step(s) browser_tests