Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

Issue 1161683002: dart2js cps: 'is' checks on types with type arguments. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Status file Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('k') | pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
index c2e67b79e046a8c5be4abdd3ad8bf05495631959..fe216b17377bc80c77477838d2a9ab97b6fb57d4 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
@@ -330,13 +330,14 @@ class LiteralMap extends Expression {
}
}
-/// Given the interceptor for a value, test the value against a type.
class TypeOperator extends Expression {
- Expression receiver;
+ Expression value;
final DartType type;
+ final List<Expression> typeArguments;
final bool isTypeTest;
- TypeOperator(this.receiver, this.type, {bool this.isTypeTest});
+ TypeOperator(this.value, this.type, this.typeArguments,
+ {bool this.isTypeTest});
accept(ExpressionVisitor visitor) => visitor.visitTypeOperator(this);
accept1(ExpressionVisitor1 visitor, arg) {
@@ -1157,7 +1158,8 @@ abstract class RecursiveVisitor implements StatementVisitor, ExpressionVisitor {
}
visitTypeOperator(TypeOperator node) {
- visitExpression(node.receiver);
+ visitExpression(node.value);
+ node.typeArguments.forEach(visitExpression);
}
visitFunctionExpression(FunctionExpression node) {
@@ -1349,7 +1351,8 @@ class RecursiveTransformer extends Transformer {
}
visitTypeOperator(TypeOperator node) {
- node.receiver = visitExpression(node.receiver);
+ node.value = visitExpression(node.value);
+ _replaceExpressions(node.typeArguments);
return node;
}
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('k') | pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698