components/plugins/renderer/webview_plugin.h - Issue 116163008: Move the plugin placeholder from CppBoundClass to gin::Wrappable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/webview_plugin.h

Issue 116163008: Move the plugin placeholder from CppBoundClass to gin::Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: counter-proposal Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/plugins/renderer/webview_plugin.h

diff --git a/components/plugins/renderer/webview_plugin.h b/components/plugins/renderer/webview_plugin.h

index e4482f83b540042bffd11d6948943384d58789e2..2efeaecf518d054a44d38a4971306e1b9ec9855c 100644

--- a/components/plugins/renderer/webview_plugin.h

+++ b/components/plugins/renderer/webview_plugin.h

@@ -40,10 +40,6 @@ class WebViewPlugin : public blink::WebPlugin,

// This method is called from WebFrameClient::didClearWindowObject.

virtual void BindWebFrame(blink::WebFrame* frame) = 0;

- // Called before the WebViewPlugin is destroyed. The delegate should delete

- // itself here.

- virtual void WillDestroyPlugin() = 0;

// Called upon a context menu event.

virtual void ShowContextMenu(const blink::WebMouseEvent&) = 0;

};