Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: components/plugins/renderer/webview_plugin.h

Issue 116163008: Move the plugin placeholder from CppBoundClass to gin::Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/plugins/renderer/plugin_placeholder.cc ('k') | components/plugins/renderer/webview_plugin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/plugins/renderer/webview_plugin.h
diff --git a/components/plugins/renderer/webview_plugin.h b/components/plugins/renderer/webview_plugin.h
index 8ec76c46caa493cfb509ae210cd36f1b1d112ede..4f463a72f3a66ec333cf5b1fdb4484c5fc88e807 100644
--- a/components/plugins/renderer/webview_plugin.h
+++ b/components/plugins/renderer/webview_plugin.h
@@ -40,10 +40,6 @@ class WebViewPlugin : public blink::WebPlugin,
// This method is called from WebFrameClient::didClearWindowObject.
virtual void BindWebFrame(blink::WebFrame* frame) = 0;
- // Called before the WebViewPlugin is destroyed. The delegate should delete
- // itself here.
- virtual void WillDestroyPlugin() = 0;
-
// Called upon a context menu event.
virtual void ShowContextMenu(const blink::WebMouseEvent&) = 0;
};
@@ -136,13 +132,17 @@ class WebViewPlugin : public blink::WebPlugin,
friend class base::DeleteHelper<WebViewPlugin>;
virtual ~WebViewPlugin();
+ // Manages its own lifetime.
Delegate* delegate_;
- // Destroys itself.
+
blink::WebCursorInfo current_cursor_;
+
// Owns us.
blink::WebPluginContainer* container_;
+
// Owned by us, deleted via |close()|.
blink::WebView* web_view_;
+
// Owned by us, deleted via |close()|.
blink::WebFrame* web_frame_;
gfx::Rect rect_;
« no previous file with comments | « components/plugins/renderer/plugin_placeholder.cc ('k') | components/plugins/renderer/webview_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698