Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3802)

Unified Diff: chrome/renderer/plugins/chrome_plugin_placeholder.h

Issue 116163008: Move the plugin placeholder from CppBoundClass to gin::Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/plugins/DEPS ('k') | chrome/renderer/plugins/chrome_plugin_placeholder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/plugins/chrome_plugin_placeholder.h
diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.h b/chrome/renderer/plugins/chrome_plugin_placeholder.h
index 66869207a28f81c431a7ffb40d04b4af6a1ec222..d7d1d81e2e10b9ea0b1d59a3398a63f8bd19bf43 100644
--- a/chrome/renderer/plugins/chrome_plugin_placeholder.h
+++ b/chrome/renderer/plugins/chrome_plugin_placeholder.h
@@ -52,6 +52,10 @@ class ChromePluginPlaceholder : public plugins::PluginPlaceholder,
// WebViewPlugin::Delegate (via PluginPlaceholder) method
virtual void BindWebFrame(blink::WebFrame* frame) OVERRIDE;
+ // gin::Wrappable (via PluginPlaceholder) method
+ virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
+ v8::Isolate* isolate) OVERRIDE;
+
// content::RenderViewObserver (via PluginPlaceholder) override:
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
@@ -66,9 +70,7 @@ class ChromePluginPlaceholder : public plugins::PluginPlaceholder,
virtual void OnMenuClosed(int request_id) OVERRIDE;
// Javascript callback opens chrome://plugins in a new tab.
- // Arguments are required by the caller, but not used.
- void OpenAboutPluginsCallback(const webkit_glue::CppArgumentList& args,
- webkit_glue::CppVariant* result);
+ void OpenAboutPluginsCallback();
void OnLoadBlockedPlugins(const std::string& identifier);
void OnSetIsPrerendering(bool is_prerendering);
« no previous file with comments | « chrome/renderer/plugins/DEPS ('k') | chrome/renderer/plugins/chrome_plugin_placeholder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698