components/plugins/renderer/webview_plugin.cc - Issue 116163008: Move the plugin placeholder from CppBoundClass to gin::Wrappable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/webview_plugin.cc

Issue 116163008: Move the plugin placeholder from CppBoundClass to gin::Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/plugins/renderer/webview_plugin.cc

diff --git a/components/plugins/renderer/webview_plugin.cc b/components/plugins/renderer/webview_plugin.cc

index 7d8b9fe5bd471f82c5fc974d374580dcb4b9d5d3..8c88c7c6928c9ff5b66134ff3d5465a09ef03976 100644

--- a/components/plugins/renderer/webview_plugin.cc

+++ b/components/plugins/renderer/webview_plugin.cc

@@ -101,10 +101,8 @@ bool WebViewPlugin::initialize(WebPluginContainer* container) {

}

void WebViewPlugin::destroy() {

- if (delegate_) {

- delegate_->WillDestroyPlugin();

Bernhard Bauer 2013/12/18 15:31:04 How does the delegate get destroyed now?

+ if (delegate_)

delegate_ = NULL;

- }

container_ = NULL;

base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);

}