Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: components/plugins/renderer/mobile_youtube_plugin.h

Issue 116163008: Move the plugin placeholder from CppBoundClass to gin::Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/plugins/renderer/mobile_youtube_plugin.h
diff --git a/components/plugins/renderer/mobile_youtube_plugin.h b/components/plugins/renderer/mobile_youtube_plugin.h
index 2fad63a032aee01041b33579f158ffc45502cc60..ac7b4f314176e7ea22e022f77d034360193fa845 100644
--- a/components/plugins/renderer/mobile_youtube_plugin.h
+++ b/components/plugins/renderer/mobile_youtube_plugin.h
@@ -6,6 +6,7 @@
#define COMPONENTS_PLUGINS_RENDERER_MOBILE_YOUTUBE_PLUGIN_H_
#include "components/plugins/renderer/plugin_placeholder.h"
+#include "gin/wrappable.h"
namespace plugins {
@@ -14,8 +15,12 @@ namespace plugins {
// of http://www.youtube.com/v/VIDEO_ID. This placeholder replaces the url with
// a simple html page and clicking the play image redirects the user to the
// mobile youtube app.
-class MobileYouTubePlugin : public PluginPlaceholder {
+class MobileYouTubePlugin : public PluginPlaceholder,
+ public gin::Wrappable<MobileYouTubePlugin> {
public:
+ static gin::WrapperInfo kWrapperInfo;
+ static v8::Local<v8::ObjectTemplate> GetObjectTemplate(v8::Isolate* isolate);
+
MobileYouTubePlugin(content::RenderFrame* render_frame,
blink::WebFrame* frame,
const blink::WebPluginParams& params,
@@ -26,9 +31,10 @@ class MobileYouTubePlugin : public PluginPlaceholder {
static bool IsYouTubeURL(const GURL& url, const std::string& mime_type);
private:
+ virtual ~MobileYouTubePlugin();
+
// Opens a youtube app in the current tab.
- void OpenYoutubeUrlCallback(const webkit_glue::CppArgumentList& args,
- webkit_glue::CppVariant* result);
+ void OpenYoutubeUrlCallback();
// WebViewPlugin::Delegate (via PluginPlaceholder) method
virtual void BindWebFrame(blink::WebFrame* frame) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698