Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Unified Diff: chrome/renderer/plugins/chrome_plugin_placeholder.h

Issue 116163008: Move the plugin placeholder from CppBoundClass to gin::Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/plugins/chrome_plugin_placeholder.h
diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.h b/chrome/renderer/plugins/chrome_plugin_placeholder.h
index 66869207a28f81c431a7ffb40d04b4af6a1ec222..1dac496d0e2df2880724fabd6b237efadb4e4258 100644
--- a/chrome/renderer/plugins/chrome_plugin_placeholder.h
+++ b/chrome/renderer/plugins/chrome_plugin_placeholder.h
@@ -6,13 +6,18 @@
#define CHROME_RENDERER_PLUGINS_CHROME_PLUGIN_PLACEHOLDER_H_
#include "components/plugins/renderer/plugin_placeholder.h"
+#include "gin/wrappable.h"
struct ChromeViewHostMsg_GetPluginInfo_Status;
class ChromePluginPlaceholder : public plugins::PluginPlaceholder,
public content::RenderProcessObserver,
- public content::ContextMenuClient {
+ public content::ContextMenuClient,
+ public gin::Wrappable<ChromePluginPlaceholder> {
public:
+ static gin::WrapperInfo kWrapperInfo;
+ static v8::Local<v8::ObjectTemplate> GetObjectTemplate(v8::Isolate* isolate);
+
static const char kPluginPlaceholderDataURL[];
static ChromePluginPlaceholder* CreateBlockedPlugin(
@@ -66,9 +71,7 @@ class ChromePluginPlaceholder : public plugins::PluginPlaceholder,
virtual void OnMenuClosed(int request_id) OVERRIDE;
// Javascript callback opens chrome://plugins in a new tab.
- // Arguments are required by the caller, but not used.
- void OpenAboutPluginsCallback(const webkit_glue::CppArgumentList& args,
- webkit_glue::CppVariant* result);
+ void OpenAboutPluginsCallback();
void OnLoadBlockedPlugins(const std::string& identifier);
void OnSetIsPrerendering(bool is_prerendering);

Powered by Google App Engine
This is Rietveld 408576698