Move the plugin placeholder from CppBoundClass to gin::Wrappable

components/plugins/renderer/webview_plugin.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
 #define COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
 
 #include <list>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 22 matching lines @@
                       public blink::WebViewClient,
                       public blink::WebFrameClient {
  public:
   class Delegate {
    public:
     // Bind |frame| to a Javascript object, enabling the delegate to receive
     // callback methods from Javascript inside the WebFrame.
     // This method is called from WebFrameClient::didClearWindowObject.
     virtual void BindWebFrame(blink::WebFrame* frame) = 0;
 
-    // Called before the WebViewPlugin is destroyed. The delegate should delete
-    // itself here.
-    virtual void WillDestroyPlugin() = 0;
-
     // Called upon a context menu event.
     virtual void ShowContextMenu(const blink::WebMouseEvent&) = 0;
   };
 
   explicit WebViewPlugin(Delegate* delegate);
 
   // Convenience method to set up a new WebViewPlugin using |preferences|
   // and displaying |html_data|. |url| should be a (fake) chrome:// URL; it is
   // only used for navigation and never actually resolved.
   static WebViewPlugin* Create(Delegate* delegate,
@@ skipping 73 matching lines @@
   // (which does nothing) to correctly overload it.
   virtual void didReceiveResponse(blink::WebFrame* frame,
                                   unsigned identifier,
                                   const blink::WebURLResponse& response);
 
  private:
   friend class base::DeleteHelper<WebViewPlugin>;
   virtual ~WebViewPlugin();
 
   Delegate* delegate_;
   // Destroys itself.

[Bernhard Bauer, 2014/01/07 09:35:42]

I think this comment refers to |delegate_| and somehow moved down a line. It's
also not quite accurate anymore (okay, technically the delegate does destroy
itself, but it's garbage-collected).

Also, could you insert blank lines before the comments here so it's clear in the
future what they refer to?

[jochen (gone - plz use gerrit), 2014/01/08 19:18:23]

Done.

   blink::WebCursorInfo current_cursor_;
   // Owns us.
   blink::WebPluginContainer* container_;
   // Owned by us, deleted via |close()|.
   blink::WebView* web_view_;
   gfx::Rect rect_;
 
   blink::WebURLResponse response_;
   std::list<std::string> data_;
   bool finished_loading_;
   scoped_ptr<blink::WebURLError> error_;
   blink::WebString old_title_;
 };
 
 #endif  // COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_