Issue 1161623004: Remove backface visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161623004: Remove backface visibility (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove backface visibility I made one edit in FrameView while looking at writing RenderParagraph in Dart and then decided to look for a slightly larger clean-up to justify committing it. I found backface-visibility which I removed. backface-visibility controls painting/hittesting of flipped objects. https://developer.mozilla.org/en-US/docs/Web/CSS/backface-visibility It's mostly used as a hack to get layers however. :) TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4536ecebc06fdc1298a7a424cf846303ae505c34

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -84 lines)			Patch
M	sky/engine/core/css/CSSComputedStyleDeclaration.cpp	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/css/CSSPrimitiveValueMappings.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	sky/engine/core/css/CSSProperties.in	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/css/parser/BisonCSSParser-in.cpp	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderBox.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	sky/engine/core/rendering/RenderObject.h	View	4 chunks	+1 line, -6 lines	0 comments	Download
M	sky/engine/core/rendering/RenderObject.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/rendering/style/RenderStyle.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/style/RenderStyleConstants.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/rendering/style/StyleRareNonInheritedData.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/public/platform/WebLayer.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 1 (0 generated)

eseidel

5 years, 6 months ago (2015-05-28 17:18:30 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4536ecebc06fdc1298a7a424cf846303ae505c34 (presubmit successful).