Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/type-feedback-vector.cc

Issue 1161623002: VectorICs: allocating slots for store ics in ast nodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Code comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/type-feedback-vector.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/type-feedback-vector.cc
diff --git a/src/type-feedback-vector.cc b/src/type-feedback-vector.cc
index 3aa55e7a805d7be5650c39e9e27b245285282ae9..e3703a93d108b6a99dde84723f2c78591e8beda6 100644
--- a/src/type-feedback-vector.cc
+++ b/src/type-feedback-vector.cc
@@ -23,6 +23,12 @@ TypeFeedbackVector::VectorICKind TypeFeedbackVector::FromCodeKind(
return KindLoadIC;
case Code::KEYED_LOAD_IC:
return KindKeyedLoadIC;
+ case Code::STORE_IC:
+ DCHECK(FLAG_vector_stores);
+ return KindStoreIC;
+ case Code::KEYED_STORE_IC:
+ DCHECK(FLAG_vector_stores);
+ return KindKeyedStoreIC;
default:
// Shouldn't get here.
UNREACHABLE();
@@ -41,6 +47,12 @@ Code::Kind TypeFeedbackVector::FromVectorICKind(VectorICKind kind) {
return Code::LOAD_IC;
case KindKeyedLoadIC:
return Code::KEYED_LOAD_IC;
+ case KindStoreIC:
+ DCHECK(FLAG_vector_stores);
+ return Code::STORE_IC;
+ case KindKeyedStoreIC:
+ DCHECK(FLAG_vector_stores);
+ return Code::KEYED_STORE_IC;
case KindUnused:
break;
}
@@ -200,6 +212,8 @@ void TypeFeedbackVector::ClearICSlotsImpl(SharedFunctionInfo* shared,
KeyedLoadICNexus nexus(this, slot);
nexus.Clear(host);
}
+ // TODO(mvstanton): Handle clearing of store ics when FLAG_vector_stores
+ // is true.
}
}
}
« no previous file with comments | « src/type-feedback-vector.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698