Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1161603004: PPC: [es6] Support super.property in eval and arrow functions (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Support super.property in eval and arrow functions Port 44e9810345cea9bfd6861905bc6856db7db5a25c Original commit message: When we enter a method that needs access to the [[HomeObject]] we allocate a local variable `.home_object` and assign it the value from the [[HomeObject]] private symbol. Something along the lines of: method() { var .home_object = %ThisFunction()[home_object_symbol]; ... } R=arv@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/4070b20aee56f1c3ffb2bf464eee53c709a83421 Cr-Commit-Position: refs/heads/master@{#28665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -41 lines) Patch
M src/ppc/full-codegen-ppc.cc View 13 chunks +37 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-27 16:51:23 UTC) #1
dstence
lgtm
5 years, 7 months ago (2015-05-27 16:59:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161603004/1
5 years, 7 months ago (2015-05-27 17:00:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 17:22:03 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 17:22:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4070b20aee56f1c3ffb2bf464eee53c709a83421
Cr-Commit-Position: refs/heads/master@{#28665}

Powered by Google App Engine
This is Rietveld 408576698