Issue 1161603003: Have the authenticating_url_loader cache token per-origin.

Issue 1161603003: Have the authenticating_url_loader cache token per-origin. (Closed)

Created:
5 years, 7 months ago by qsr

Modified:
5 years, 7 months ago

Reviewers:
blundell

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Have the authenticating_url_loader cache token per-origin. R=blundell@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/33533950a9d830d542cdffcbf84dfd1d61a2415d

Patch Set 1 #

Total comments: 4

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -4 lines)			Patch
M	services/authenticating_url_loader/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	services/authenticating_url_loader/authenticating_url_loader_factory_impl.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	services/authenticating_url_loader/authenticating_url_loader_factory_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	services/authenticating_url_loader/authenticating_url_loader_impl.h	View	3 chunks	+4 lines, -1 line	2 comments	Download
M	services/authenticating_url_loader/authenticating_url_loader_impl.cc	View	4 chunks	+11 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blundell

lgtm https://codereview.chromium.org/1161603003/diff/1/services/authenticating_url_loader/authenticating_url_loader_impl.cc File services/authenticating_url_loader/authenticating_url_loader_impl.cc (right): https://codereview.chromium.org/1161603003/diff/1/services/authenticating_url_loader/authenticating_url_loader_impl.cc#newcode48 services/authenticating_url_loader/authenticating_url_loader_impl.cc:48: GURL url(request->url); nit: unneeded, just use |url_|. https://codereview.chromium.org/1161603003/diff/1/services/authenticating_url_loader/authenticating_url_loader_impl.h ...

5 years, 7 months ago (2015-05-27 15:43:44 UTC) #2

qsr

https://codereview.chromium.org/1161603003/diff/1/services/authenticating_url_loader/authenticating_url_loader_impl.cc File services/authenticating_url_loader/authenticating_url_loader_impl.cc (right): https://codereview.chromium.org/1161603003/diff/1/services/authenticating_url_loader/authenticating_url_loader_impl.cc#newcode48 services/authenticating_url_loader/authenticating_url_loader_impl.cc:48: GURL url(request->url); On 2015/05/27 15:43:44, blundell wrote: > nit: ...

5 years, 7 months ago (2015-05-27 16:02:27 UTC) #3

qsr

5 years, 7 months ago (2015-05-27 16:08:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
33533950a9d830d542cdffcbf84dfd1d61a2415d (presubmit successful).

Expand Messages | Collapse Messages