Issue 1161583002: [turbofan] Properly kill Terminate nodes when removing loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161583002: [turbofan] Properly kill Terminate nodes when removing loops. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer

Modified:
5 years, 7 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Properly kill Terminate nodes when removing loops. BUG=chromium:491578 LOG=n R=jarin@chromium.org Committed: https://crrev.com/b53c35a797a37345a1f912ecd51baa651be911c6 Cr-Commit-Position: refs/heads/master@{#28621}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	src/compiler/control-reducer.cc	View		2 chunks	+10 lines, -2 lines	0 comments	Download
	A +	test/mjsunit/compiler/regress-491578.js	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Total messages: 7 (1 generated)

Benedikt Meurer

Hey Jaro, We need to remove Terminate together with the Loop to which it belongs. ...

5 years, 7 months ago (2015-05-26 10:26:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161583002/1

5 years, 7 months ago (2015-05-26 10:35:35 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-26 10:48:16 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b53c35a797a37345a1f912ecd51baa651be911c6
Cr-Commit-Position: refs/heads/master@{#28621}