Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1161563002: Remove unused in-process pepper APIs (Closed)

Created:
5 years, 7 months ago by raymes
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang, bbudge, binji
CC:
binji+watch_chromium.org, bradnelson+warch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, ihf+watch_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, raymes+watch_chromium.org, Sam Clegg, teravest+watch_chromium.org, tzik, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused in-process pepper APIs Several APIs are now unused after turning on OOP PDF. This removes: Selection_Dev Widget_Dev Scrollbar_Dev Zoom_Dev These APIs only work in-process so we can be sure they aren't used by existing plugins (except possibly the NaCl plugin but they aren't used by that either). BUG=303491 Committed: https://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235 Cr-Commit-Position: refs/heads/master@{#331904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2417 lines) Patch
M chrome/common/ppapi_utils.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 5 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 7 chunks +0 lines, -47 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 3 chunks +0 lines, -4 lines 0 comments Download
D content/renderer/pepper/ppb_scrollbar_impl.h View 1 chunk +0 lines, -75 lines 0 comments Download
D content/renderer/pepper/ppb_scrollbar_impl.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D content/renderer/pepper/ppb_widget_impl.h View 1 chunk +0 lines, -63 lines 0 comments Download
D content/renderer/pepper/ppb_widget_impl.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M content/renderer/pepper/resource_creation_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/resource_creation_impl.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi/library.dsc View 1 chunk +0 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 2 chunks +0 lines, -5 lines 0 comments Download
M pdf/out_of_process_instance.h View 3 chunks +0 lines, -5 lines 0 comments Download
M pdf/out_of_process_instance.cc View 2 chunks +0 lines, -7 lines 0 comments Download
D ppapi/api/dev/ppb_scrollbar_dev.idl View 1 chunk +0 lines, -82 lines 0 comments Download
D ppapi/api/dev/ppb_widget_dev.idl View 1 chunk +0 lines, -63 lines 0 comments Download
D ppapi/api/dev/ppb_zoom_dev.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D ppapi/api/dev/ppp_scrollbar_dev.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D ppapi/api/dev/ppp_selection_dev.idl View 1 chunk +0 lines, -22 lines 0 comments Download
D ppapi/api/dev/ppp_widget_dev.idl View 1 chunk +0 lines, -26 lines 0 comments Download
D ppapi/api/dev/ppp_zoom_dev.idl View 1 chunk +0 lines, -27 lines 0 comments Download
D ppapi/c/dev/ppb_scrollbar_dev.h View 1 chunk +0 lines, -106 lines 0 comments Download
D ppapi/c/dev/ppb_widget_dev.h View 1 chunk +0 lines, -84 lines 0 comments Download
D ppapi/c/dev/ppb_zoom_dev.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ppapi/c/dev/ppp_scrollbar_dev.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ppapi/c/dev/ppp_selection_dev.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ppapi/c/dev/ppp_widget_dev.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ppapi/c/dev/ppp_zoom_dev.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ppapi/cpp/dev/scrollbar_dev.h View 1 chunk +0 lines, -39 lines 0 comments Download
D ppapi/cpp/dev/scrollbar_dev.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D ppapi/cpp/dev/selection_dev.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ppapi/cpp/dev/selection_dev.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D ppapi/cpp/dev/widget_client_dev.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ppapi/cpp/dev/widget_client_dev.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D ppapi/cpp/dev/widget_dev.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ppapi/cpp/dev/widget_dev.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D ppapi/cpp/dev/zoom_dev.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ppapi/cpp/dev/zoom_dev.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 8 chunks +0 lines, -58 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 3 chunks +0 lines, -6 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 4 chunks +0 lines, -19 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/tests/test_case.h View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/tests/test_scrollbar.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ppapi/tests/test_scrollbar.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M ppapi/thunk/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 chunk +0 lines, -5 lines 0 comments Download
D ppapi/thunk/ppb_scrollbar_api.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ppapi/thunk/ppb_scrollbar_thunk.cc View 1 chunk +0 lines, -95 lines 0 comments Download
M ppapi/thunk/ppb_video_encoder_thunk.cc View 2 chunks +4 lines, -7 lines 0 comments Download
D ppapi/thunk/ppb_widget_api.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ppapi/thunk/ppb_widget_dev_thunk.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D ppapi/thunk/ppb_zoom_dev_thunk.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
raymes
5 years, 7 months ago (2015-05-27 03:17:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161563002/1
5 years, 7 months ago (2015-05-27 03:18:15 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-27 05:35:38 UTC) #6
bbudge
LGTM = looks great to me.
5 years, 7 months ago (2015-05-27 07:14:37 UTC) #7
raymes
+OWNERS +binji for native_client_sdk/* +thestig for trivial changes to chrome/common/ppapi_utils.cc
5 years, 7 months ago (2015-05-28 00:43:50 UTC) #9
Lei Zhang
chrome/ lgtm
5 years, 7 months ago (2015-05-28 00:58:42 UTC) #10
binji
native_client_sdk lgtm
5 years, 6 months ago (2015-05-28 17:52:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161563002/1
5 years, 6 months ago (2015-05-28 23:35:30 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 01:32:04 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 01:32:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235
Cr-Commit-Position: refs/heads/master@{#331904}

Powered by Google App Engine
This is Rietveld 408576698