Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1161543003: Set GeometryBufferMapThreshold defaults (Closed)

Created:
5 years, 6 months ago by joshua.litt
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M include/gpu/GrCaps.h View 3 chunks +2 lines, -1 line 0 comments Download
M include/gpu/GrContextOptions.h View 1 2 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
joshualitt
5 years, 6 months ago (2015-05-29 18:43:20 UTC) #2
bsalomon
https://codereview.chromium.org/1161543003/diff/1/include/gpu/GrContextOptions.h File include/gpu/GrContextOptions.h (right): https://codereview.chromium.org/1161543003/diff/1/include/gpu/GrContextOptions.h#newcode40 include/gpu/GrContextOptions.h:40: int fGeometryBufferMapThreshold; This comment is a bit impl specific ...
5 years, 6 months ago (2015-06-01 13:53:06 UTC) #3
robertphillips
lgtm. Is there any perf improvement in Chrome?
5 years, 6 months ago (2015-06-01 14:02:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161543003/20001
5 years, 6 months ago (2015-06-01 21:08:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/225)
5 years, 6 months ago (2015-06-01 21:09:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161543003/20001
5 years, 6 months ago (2015-06-01 21:17:21 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 21:17:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e5b74c68564baab3639b21a95ce5b4b92949ca27

Powered by Google App Engine
This is Rietveld 408576698