Fix crash when backgrounding MojoShell on Android. Fixes issue #186.

Fix crash when backgrounding MojoShell on Android. Fixes issue #186.

When backgrounding MojoShell while running spinning-square.sky (in sky viewer), we had a crash due to CommandBufferImpl binding on one thread, but destroying its binding on another thread (hence the underlying HandleWatcher didn't get removed correctly from the right run loop).

This CL fixes the issue by making sure binding and destruction happen on the same thread, control_task_runner.

R=qsr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/6d38eec257948d6a70815fd810788daac187fcec

[etiennej, 2015-06-02 14:36:03]

Patchset #2 (id:20001) has been deleted

[etiennej, 2015-06-02 14:50:45]

etiennej@chromium.org changed reviewers:
+ blundell@chromium.org, qsr@chromium.org

[etiennej, 2015-06-03 14:43:55]

Changes per offline discussion

[blundell, 2015-06-03 14:48:59]

https://codereview.chromium.org/1161533005/diff/40001/services/gles2/command_...
File services/gles2/command_buffer_impl.cc (right):

https://codereview.chromium.org/1161533005/diff/40001/services/gles2/command_...
services/gles2/command_buffer_impl.cc:152: NotifyAndDestroy();
This method is called on |control_task_runner_| at line 38 of this file, right?

[etiennej, 2015-06-03 15:00:40]

https://codereview.chromium.org/1161533005/diff/40001/services/gles2/command_...
File services/gles2/command_buffer_impl.cc (right):

https://codereview.chromium.org/1161533005/diff/40001/services/gles2/command_...
services/gles2/command_buffer_impl.cc:152: NotifyAndDestroy();
On 2015/06/03 14:48:59, blundell wrote:
> This method is called on |control_task_runner_| at line 38 of this file,
right?

Right. Fixed.

[blundell, 2015-06-03 16:29:44]

This looks OK to me but I think that James should weigh in as well. It would be
helpful to expand the CL description to include the symptoms that you were
seeing and your diagnosis of the problem, as well as your solution :).

[etiennej, 2015-06-03 16:44:21]

etiennej@chromium.org changed reviewers:
+ jamesr@chromium.org

[etiennej, 2015-06-03 16:44:22]

James, could you take a look at this change? Thanks.

[qsr, 2015-06-04 09:02:17]

James being out for a month. LGTM. We can always go back to this when he is
back.

[etiennej, 2015-06-04 09:49:10]

Committed patchset #3 (id:60001) manually as
6d38eec257948d6a70815fd810788daac187fcec (presubmit successful).