Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1161533003: Update cmake generator to handle Skia Android build. (Closed)

Created:
5 years, 7 months ago by bungeman-chromium
Modified:
5 years, 6 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Update cmake generator to handle Skia Android build. These changes bring the cmake generator more in line with the ninja generator: 1. Set the default linker language to 'C' when there are no files. This allows targets without sources to link multiple so's. 2. Use 'CC', 'CXX', and 'AR' when specified. 3. Separate sources into CMake lists early to avoid repeating names. This greatly reduces the size of the resulting CMakeLists.txt. R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/08429da7955a98ef764fafa223dd7de73f654b2d

Patch Set 1 #

Patch Set 2 : Remove debugging lines. #

Patch Set 3 : Add double quote to bad characters for target. #

Patch Set 4 : Fix trans length. #

Patch Set 5 : Fix executables with no inputs. #

Patch Set 6 : Correctly write variables. #

Total comments: 1

Patch Set 7 : Fix source edge case, simple make_global_settings handling. #

Patch Set 8 : Don't output includes and flags for 'none' targets. #

Patch Set 9 : Handle long link lines and linkable sources. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -153 lines) Patch
M pylib/gyp/generator/cmake.py View 1 2 3 4 5 6 7 8 9 chunks +231 lines, -153 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
bungeman-chromium
This is somewhat cumulative and fixes a few issues I had when building various projects ...
5 years, 7 months ago (2015-05-26 22:42:32 UTC) #2
Nico
rs-lgtm https://codereview.chromium.org/1161533003/diff/100001/pylib/gyp/generator/cmake.py File pylib/gyp/generator/cmake.py (right): https://codereview.chromium.org/1161533003/diff/100001/pylib/gyp/generator/cmake.py#newcode733 pylib/gyp/generator/cmake.py:733: if target_type == 'executable' and not has_sources: Does ...
5 years, 7 months ago (2015-05-27 20:11:49 UTC) #3
bungeman-chromium
On 2015/05/27 20:11:49, Nico wrote: > rs-lgtm > > https://codereview.chromium.org/1161533003/diff/100001/pylib/gyp/generator/cmake.py > File pylib/gyp/generator/cmake.py (right): > ...
5 years, 7 months ago (2015-05-27 20:19:50 UTC) #4
bungeman-chromium
5 years, 6 months ago (2015-05-29 19:51:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #9 (id:150001) manually as
08429da7955a98ef764fafa223dd7de73f654b2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698