IDL compiler: [NamedConstructor] (basic)

Source/bindings/templates/methods.cpp

Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 373ef448bb56654d2512d6ba4cfcae65e818a8ca..f534272324cdea3d0ee9da72145045056d630ccf 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -292,7 +292,7 @@ static void {{method.name}}OriginSafeMethodGetterCallback{{world_suffix}}(v8::Lo
 
 
 {##############################################################################}
-{% macro constructor_callback(constructor) %}
+{% macro generate_constructor(constructor) %}
 static void constructor{{constructor.overload_index}}(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     {% if interface_length and not constructor.overload_index %}
@@ -329,3 +329,35 @@ static void constructor{{constructor.overload_index}}(const v8::FunctionCallback
     v8SetReturnValue(info, wrapper);
 }
 {% endmacro %}
+
+
+{##############################################################################}
+{% macro named_constructor_callback(constructor) %}
+static void {{v8_class}}ConstructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
+{
+    if (!info.IsConstructCall()) {
+        throwTypeError(ExceptionMessages::failedToConstruct("{{constructor.name}}", "Please use the 'new' operator, this DOM object constructor cannot be called as a function."), info.GetIsolate());

[haraken, 2013/12/16 08:56:18]

Use throw_type_error.

[Nils Barth (inactive), 2013/12/16 09:29:45]

This one case is easier to do literally, because otherwise we'd need
to pass the name around and it would make all other calls longer
(or add *another* level of abstraction (>.<)).
Named constructors are rare and simple, so I'd rather not make the rest of
the code complicated for this case.

+        return;
+    }
+
+    if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) {
+        v8SetReturnValue(info, info.Holder());
+        return;
+    }
+
+    Document* document = currentDocument();
+    ASSERT(document);
+
+    // Make sure the document is added to the DOM Node map. Otherwise, the {{cpp_class}} instance
+    // may end up being the only node in the map and get garbage-collected prematurely.
+    toV8(document, info.Holder(), info.GetIsolate());
+
+    {# FIXME: arguments #}
+    {% set argument_list = ['*document'] %}
+    RefPtr<{{cpp_class}}> impl = {{cpp_class}}::createForJSConstructor({{argument_list | join(', ')}});
+    v8::Handle<v8::Object> wrapper = info.Holder();
+
+    V8DOMWrapper::associateObjectWithWrapper<{{v8_class}}>(impl.release(), &{{v8_class}}Constructor::wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Dependent);
+    v8SetReturnValue(info, wrapper);
+}
+{% endmacro %}