chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc - Issue 11615011: Small modifications to safebrowsing code to make it simpler to add the extension

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 11615011: Small modifications to safebrowsing code to make it simpler to add the extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/download_protection_service_unittest.cc ('K') | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

index 2326c91dff634cbeefee779d33ca92884762530e..2cdb59e3c940e168ce9adfa9cfc6ab0462122ac7 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

@@ -17,6 +17,7 @@

#include "chrome/browser/safe_browsing/malware_details.h"

#include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h"

#include "chrome/browser/safe_browsing/safe_browsing_service.h"

+#include "chrome/browser/safe_browsing/safe_browsing_util.h"

#include "chrome/browser/safe_browsing/ui_manager.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_tabstrip.h"

@@ -68,10 +69,12 @@ class FakeSafeBrowsingDatabaseManager : public SafeBrowsingDatabaseManager {

}

void OnCheckBrowseURLDone(const GURL& gurl, Client* client) {

- SafeBrowsingDatabaseManager::SafeBrowsingCheck check;

- check.urls.push_back(gurl);

- check.client = client;

- check.threat_type = badurls[gurl.spec()];

+ SafeBrowsingDatabaseManager::SafeBrowsingCheck check(

+ std::vector<GURL>(1, gurl),

+ std::vector<SBFullHash>(),

+ client,

+ safe_browsing_util::MALWARE);

+ check.url_results[0] = badurls[gurl.spec()];

Scott Hess - ex-Googler 2013/01/17 19:24:42 I see that this is the same as before, just wanted

not at google - send to devlin 2013/01/18 01:02:42 I don't parse comment, sorry...

Scott Hess - ex-Googler 2013/01/18 01:27:52 badurls[gurl.spec()] will be 0 for anything that i

client->OnSafeBrowsingResult(check);

}