chrome/browser/safe_browsing/download_protection_service_unittest.cc - Issue 11615011: Small modifications to safebrowsing code to make it simpler to add the extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 11615011: Small modifications to safebrowsing code to make it simpler to add the extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/database_manager.h ('K') | « chrome/browser/safe_browsing/database_manager.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc » ('j') | chrome/browser/safe_browsing/safe_browsing_database.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service_unittest.cc b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

index 6b4a41cc40dfd400ee41ef183ce2dd10ec288b28..8e274e222eebe76e1fda13ea66e02cbd5daf2a8d 100644

--- a/chrome/browser/safe_browsing/download_protection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

@@ -128,10 +128,13 @@ void OnSafeBrowsingResult(

ACTION_P(CheckDownloadUrlDone, threat_type) {

SafeBrowsingDatabaseManager::SafeBrowsingCheck* check =

- new SafeBrowsingDatabaseManager::SafeBrowsingCheck();

+ new SafeBrowsingDatabaseManager::SafeBrowsingCheck(

+ safe_browsing_util::BINURL);

check->urls = arg0;

- check->is_download = true;

- check->threat_type = threat_type;

+ for (std::vector<GURL>::iterator it = check->urls.begin();

+ it != check->urls.end(); ++it) {

+ check->url_threats[*it] = threat_type;

+ }

check->client = arg1;

BrowserThread::PostTask(BrowserThread::IO,

FROM_HERE,