extensions/renderer/guest_view/extensions_guest_view_container_observer.cc - Issue 1161483004: Move guest view container message routing out of content/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/renderer/guest_view/extensions_guest_view_container_observer.cc

Issue 1161483004: Move guest view container message routing out of content/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix newwindow Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/renderer/content_renderer_client.h ('K') | « extensions/renderer/guest_view/extensions_guest_view_container_observer.h ('k') | extensions/shell/renderer/shell_content_renderer_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "extensions/renderer/guest_view/extensions_guest_view_container_observe r.h"

	6

	7 #include "ipc/ipc_message.h"

	8 #include "ipc/ipc_message_macros.h"

	9

	10 namespace extensions {

	11

	12 ExtensionsGuestViewContainerObserver::ExtensionsGuestViewContainerObserver() {

	13 }

	14

	15 ExtensionsGuestViewContainerObserver::~ExtensionsGuestViewContainerObserver() {

	16 }

	17

	18 bool ExtensionsGuestViewContainerObserver::HandlesMessage(

	19 const IPC::Message& message) {

	20 return (IPC_MESSAGE_CLASS(message) == GuestViewMsgStart) \|\|

	21 (IPC_MESSAGE_CLASS(message) == ExtensionsGuestViewMsgStart);
	Fady Samuel 2015/06/01 11:32:25 You only need to add this. Call the base class: r You only need to add this. Call the base class: return GuestViewContaienrObserver(message) \|\| (IPC_MESSAGE_CLASS(message) == ExtensionsGuestViewMsgStart); lazyboy 2015/06/01 16:00:07 If we disable extensions, then we shouldn't handle Show quoted text On 2015/06/01 at 11:32:25, Fady Samuel wrote: > You only need to add this. Call the base class: > > return GuestViewContaienrObserver(message) \|\| > (IPC_MESSAGE_CLASS(message) == ExtensionsGuestViewMsgStart); If we disable extensions, then we shouldn't handle ExtensionsGuestViewMsg* messages, that's why there's a separate class in chrome/* with #if (ENABLE_EXTENSIONS) to guard this bit. Let me know if I'm missing something.
	22 }

	23

	24 } // namespace extensions

OLD	NEW