Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 1161463008: Refactoring: Have StyledMarkupAccumulator use MarkupFormatter (Closed)

Created:
4 years, 11 months ago by hajimehoshi
Modified:
4 years, 11 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring: Have StyledMarkupAccumulator use MarkupFormatter StyledMarkupAccumulator is now using MarkupAccumulator. This CL replaces this usage with MarkupFormatter. MarkupAccumulator has been separated into (new) MarkupAccumulator and MarkupFormatter at crrev.com/1148633010. MarkupFormatter focuses on formatting DOM nodes to texts, and it is better for StyledMarkupAccumulator to use MarkupFormatter instead of MarkupAccumulator for code health. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196474

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -45 lines) Patch
M Source/core/editing/MarkupAccumulator.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 2 chunks +2 lines, -24 lines 0 comments Download
M Source/core/editing/MarkupFormatter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/MarkupFormatter.cpp View 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/editing/StyledMarkupAccumulator.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/editing/StyledMarkupAccumulator.cpp View 1 8 chunks +12 lines, -16 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
hajimehoshi
PTAL
4 years, 11 months ago (2015-06-04 05:41:34 UTC) #2
yosin_UTC9
https://codereview.chromium.org/1161463008/diff/20001/Source/core/editing/markup.cpp File Source/core/editing/markup.cpp (right): https://codereview.chromium.org/1161463008/diff/20001/Source/core/editing/markup.cpp#newcode49 Source/core/editing/markup.cpp:49: #include "core/editing/MarkupAccumulator.h" Q: Do we need to have this ...
4 years, 11 months ago (2015-06-04 06:05:41 UTC) #3
hajimehoshi
https://codereview.chromium.org/1161463008/diff/20001/Source/core/editing/markup.cpp File Source/core/editing/markup.cpp (right): https://codereview.chromium.org/1161463008/diff/20001/Source/core/editing/markup.cpp#newcode49 Source/core/editing/markup.cpp:49: #include "core/editing/MarkupAccumulator.h" On 2015/06/04 06:05:41, Yosi_UTC9 wrote: > Q: ...
4 years, 11 months ago (2015-06-04 06:07:39 UTC) #4
yosin_UTC9
lgtm
4 years, 11 months ago (2015-06-04 06:09:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161463008/20001
4 years, 11 months ago (2015-06-04 06:09:53 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 07:34:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196474

Powered by Google App Engine
This is Rietveld 408576698