Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(92)

Issue 1161463007: De-flaking some tests in virtual/gpu/fast/canvas (Closed)

Created:
4 years, 11 months ago by Justin Novosad
Modified:
4 years, 11 months ago
Reviewers:
Stephen White
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

De-flaking some tests in virtual/gpu/fast/canvas This change uses layoutAndPaintAsyncThen + notifyDone to fix the flakiness of some canvas layout tests with gpu acceleration enabled. This approach seems to do the trick locally. This change fixes a subset of the tests to see if this approach holds up on the test bots. If it does, the rest of the tests will be fixed in a follow-up change. BUG=410929 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196523

Patch Set 1 #

Patch Set 2 : asyncpaintguard #

Patch Set 3 : rebaselines #

Patch Set 4 : plus rebaseline #

Patch Set 5 : fix mac #

Patch Set 6 : undo previous patch (wrong issue) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +4 lines, -12 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-render-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-resize-after-paint-without-layout.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-state-persistence-no-dirty.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-state-persistence-no-dirty-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-text-baseline.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-text-space-characters.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-identity.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-identity-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-infinity.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-infinity-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-zoom.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-zoom-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/fillrect-gradient-zero-stops.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/fillrect-gradient-zero-stops-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/patternfill-repeat.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/patternfill-repeat-expected.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/canvas/resources/asyncpaintguard.js View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Justin Novosad
PTAL
4 years, 11 months ago (2015-06-04 04:45:39 UTC) #2
Stephen White
LGTM but if this is required in all cases, shouldn't we change the implementation of ...
4 years, 11 months ago (2015-06-04 15:34:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161463007/60001
4 years, 11 months ago (2015-06-04 18:05:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161463007/100001
4 years, 11 months ago (2015-06-04 19:05:38 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196523
4 years, 11 months ago (2015-06-04 19:09:40 UTC) #10
leviw_travelin_and_unemployed
4 years, 11 months ago (2015-06-04 22:31:36 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1167013003/ by leviw@chromium.org.

The reason for reverting is: Caused one odd consistent failure :(

junov will look into it tomorrow.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=vir....

Powered by Google App Engine
This is Rietveld 408576698